-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Next.js 15 #373
Comments
Hi @wei, /assign me this, I am interested to upgrade. |
Hi, I'll be happy to deliver this in the next few days. Getting a branch going on my fork right now... Edit: separated comments for clarity |
@wei I understood as you'd like to upgrade to 15 first and then do the Doing it in this order might cause unexpected issues, from the docs I've read so far; but I can first try and let you know. |
@KemingHe We can migrate in one go, no need to separate. |
It's actually 3 separate migrations:
and only the last one is confirmed stable. Should I keep the page router when doing the first two steps (they are bundled together by NextJS)? What's your recommendation? |
I see, okay. I will try a couple different ways and let you know then. This is what I was referring to: Ref https://nextjs.org/docs/app/building-your-application/upgrading/version-15 Good to know:
If you see a peer dependencies warning, you may need to update react and react-dom to the suggested versions, or you use the --force or --legacy-peer-deps flag to ignore the warning. This won't be necessary once both Next.js 15 and React 19 are stable. and we are instructed to use |
Sounds good, React 19 just turned stable so they probably need to update their docs. I just noticed https://nextjs.org/docs/messages/no-stylesheets-in-head-component please also fix as part of the upgrade if you don't mind or I can do a separate PR as well. |
No worries, this is already part of the On it right now. |
Hi @wei , I've been making great progress on the Would you like me to add API endpoint testing while I'm at it? (This will roughly double the delivery time but a must-have to ensure api consistency.) Any recommendations you'd like me to be aware of? |
Additional context: NextJS 14+ app router calls for complete API refactor, so that's why even if the api behaviors are fine (Playwright), I want a future-proof way of making sure they are internally consistent. |
That's fantastic! Let's add api testing in a separate pr after this one. Can you create an issue with your proposal of how you plan to implement api testing? I've used nock before but open to other options. |
Hello @wei , I think it'd be really helpful to the Hear from you soon! |
Awesome news: API migration confirmed working, AND the simplest way to add testing is to use Playwright to expect match snapshot, since the endpoints mostly return images. Very close to full site migration to app router. Still would appreciate a Zoom meeting to speed things up. |
Excellent, let's coordinate over dm |
Talk to you soon in LinkedIn. 🌻 |
Resolved in #450 🚀 |
https://nextjs.org/docs/app/building-your-application/upgrading/version-15
The text was updated successfully, but these errors were encountered: