fix: http announce no left #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilentBot1
approved these changes
Jan 19, 2025
webtorrent-bot
pushed a commit
that referenced
this pull request
Jan 19, 2025
## [11.2.1](v11.2.0...v11.2.1) (2025-01-19) ### Bug Fixes * http announce no left ([#548](#548)) ([3cd77f3](3cd77f3))
|
🎉 This PR is included in version 11.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
for http announce, forced left to be a defined value, while the spec doesn't say what happens when left is null, most trackers error, libtorrent simply sets it to 16k in those cases so let's follow suit
Which issue (if any) does this pull request address?
webtorrent hanging on some magnet links as it announced left undefined, which queried the tracker with
&left&Is there anything you'd like reviewers to focus on?