Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable socks in chromeapp #398

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

yrliou
Copy link
Contributor

@yrliou yrliou commented Sep 1, 2021

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
Disable socks in chromeapp

Which issue (if any) does this pull request address?
#397

Is there anything you'd like reviewers to focus on?

cc @feross

@welcome
Copy link

welcome bot commented Sep 1, 2021

🙌 Thanks for opening this pull request! You're awesome.

@DiegoRBaquero DiegoRBaquero changed the title Disable socks in chromeapp fix: disable socks in chromeapp Sep 1, 2021
@DiegoRBaquero DiegoRBaquero merged commit 7fd5877 into webtorrent:master Sep 1, 2021
@welcome
Copy link

welcome bot commented Sep 1, 2021

🎉 Congrats on getting your first pull request landed!

webtorrent-bot pushed a commit that referenced this pull request Sep 1, 2021
## [9.18.1](v9.18.0...v9.18.1) (2021-09-01)

### Bug Fixes

* disable socks in chromeapp ([#398](#398)) ([7fd5877](7fd5877))
@webtorrent-bot
Copy link

🎉 This PR is included in version 9.18.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@feross
Copy link
Member

feross commented Sep 1, 2021

Thanks for the quick merge @DiegoRBaquero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants