Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Migrate should move NamedModulesPlugin to optimizations.namedModules #394

Closed
ematipico opened this issue Apr 10, 2018 · 1 comment
Closed

[Feature] Migrate should move NamedModulesPlugin to optimizations.namedModules #394

ematipico opened this issue Apr 10, 2018 · 1 comment
Labels
Feature Help Wanted Migrate Semver: minor ⚙️ When delivering new features that don't break

Comments

@ematipico
Copy link
Contributor

ematipico commented Apr 10, 2018 •
edited
Loading

Do you want to request a feature or report a bug?
Feature.

What is the current behavior?
At the moment migrate does nothing when it encounters NamedModulesPlugin

What is the expected behavior?
It should migrate to optimizations.namedModules

If this is a feature request, what is motivation or use case for changing the behavior?
NamedModulesPlugin is now changed in webpack v4 and migrate, as its objective, should add a flag inside the optimizations object
@ematipico ematipico added Help Wanted Feature Migrate Semver: minor ⚙️ When delivering new features that don't break labels Apr 10, 2018
@evenstensberg evenstensberg added this to the Vatican (v3) milestone Apr 10, 2018
@bitpshr
Copy link
Member

bitpshr commented Apr 11, 2018

I'll take this one.

@bitpshr bitpshr mentioned this issue Apr 12, 2018
Closed
@ematipico ematipico changed the title [Feature] Migrate should NamedModulesPlugin to optimizations.namedModules [Feature] Migrate should move NamedModulesPlugin to optimizations.namedModules Apr 12, 2018
@bitpshr bitpshr mentioned this issue Apr 14, 2018
Merged
@ematipico ematipico mentioned this issue Jul 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Help Wanted Migrate Semver: minor ⚙️ When delivering new features that don't break
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bitpshr @ematipico @evenstensberg