-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting the config name for multiple configs #1657
Comments
This comment has been minimized.
This comment has been minimized.
This issue arose while using If either webpack-command or webpack-cli are actually being called in the middleware, passing whatever arguments through sounds fairly trivial. But if you're only using the API, it makes perfect sense to target specific use cases. |
Yeah take a quick peek at The |
@shellscape This would align well in a separate repo that has a options file that both |
@ev1stensberg what? no. that would be a horrible architectural decision. |
Perhaps, but it's better than directly importing the config and depending on that. A hard copy in Dev server would make it harder to maintain features if/when they are removed, added or modified |
@ev1stensberg I don't think you understand the conversation here. No one is talking about importing configs. @DBosley I'll see about getting into this next week. It may not look exactly like the suggestions you had, but pretty sure I know how we can make this happen. |
I do, config -> yargs config. Makes it possible for us to bridge the libraries better. But seems like you got this under control. |
@DBosley can you provide example how you can see this implementation? |
Probably a bit late to party. |
hey, I'm a new contributor and I'd like to take up this issue, is it available/active? |
Yes, PR welcome |
@evilebottnawi I have a suggestion we can create 2 options one is |
@EslamHiko this issue about supporting |
This issue had no activity for at least half a year. It's subject to automatic issue closing if there is no activity in the next 15 days. |
We need implement the /cc @webpack/cli-team |
@evilebottnawi multiple compilers simultaneously? |
Yes. With |
@snitin315 a heads up, the name flag will also be underwork #1649, I suggest to start working on this (if needed) after that PR gets merged to avoid duplicate work :) |
makes sense 👍 |
@evilebottnawi Now we support |
@snitin315 Let's improve it |
We should improve it at the core or here (in CLI)? |
CLI, it is out of scope core |
|
Yes, you are right |
Operating System: Ubuntu 18.04
Node Version: 8.11.1
NPM Version: 6.0.0
webpack Version: 4.12.0
webpack-hot-client Version: 4.0.3
What is the motivation and/or use-case for the feature?
Webpack supports multiple configurations in a single file by exporting an array.
Info Here
A new feature that was added recently (but currently lacks total documentation) is that you can set a 'name' property in your webpack config and pass
--config-name
to the cli to choose a specific config to build if you don't want to build all of them.This feature request is to allow support of this functionality in the webpack-dev-middleware and related plugins.
Implementing this could be done in a couple ways:
I think the first solution is going to be the best approach if it's possible. This is because it would allow any webpack-cli arguments to be used with middlewares. If for some reason there's no way to go down this route, the second option would suffice for my use case, but it might be a good idea to look at other options listed here to see if they would merit being included as well
The text was updated successfully, but these errors were encountered: