Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support not keyword #53

Merged
merged 1 commit into from
Sep 26, 2019
Merged

feat: support not keyword #53

merged 1 commit into from
Sep 26, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Support not keyword

Breaking Changes

No

Additional Info

Some messages can be invalid need more tests

For example:

{ "not": { "minimum": 3 } }

Should output should not be < 3 or any non-number

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #53 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   98.49%   98.51%   +0.01%     
==========================================
  Files           4        4              
  Lines         466      472       +6     
  Branches      211      215       +4     
==========================================
+ Hits          459      465       +6     
  Misses          7        7
Impacted Files Coverage Δ
src/ValidationError.js 98.27% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c955650...2f20c9c. Read the comment docs.

@alexander-akait alexander-akait merged commit 765f458 into master Sep 26, 2019
@alexander-akait alexander-akait deleted the feat-not-keyword branch September 26, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant