This repository was archived by the owner on Mar 17, 2021. It is now read-only.
fix(index): revert to CJS exports #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 35 35
Branches 16 16
=====================================
Hits 35 35
Continue to review full report at Codecov.
|
|
(for what it's worth, I was hitting the issue too and your patch fixes it. Thanks!) |
joshwiens
approved these changes
Sep 30, 2017
michael-ciniawsky
added
status: Approved
and removed
priority: 2 (urgent)
pr_action: Review
severity: 2 (regression)
status: Pending
labels
sepe81
referenced
this pull request
Jan 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noteable Changes
css-loadersadly expects CJS exports for asset resolving and there isn't a convenient way to fix it directly incss-loaderatm. ES2015 Modules exports will have to wait until the new CSS Pipeline is in place or a major version bump incss-loaderis accepted. Note that CJS <=> ESM doesn't really matter here since we export one static value (Filepath {String}) only anyways.Issues
url()broken (css-loader) #181