Remove superseded SelectionMover class #730
Conversation
|
Build succeeded. |
| @@ -692,18 +690,12 @@ gui.DirectFormattingController = function DirectFormattingController( | |||
| * @return {boolean} | |||
There was a problem hiding this comment.
While touching this code please improve the API dox to mention that this is about the last paragraph touched by the range, not the last paragraph of the document (wrong understanding took me some time, thankfully @adityab pointed me the right way in the end).
|
Changes otherwise look okay to me 🍰 , but for some proper testing needs first to be rebased to latest master (not only to get the fixes of #747). |
The removed tests have been superseded by SelectionController tests covering the same functionality.
|
Build succeeded. |
|
Build succeeded. |
|
Oh, one more thing, I haven't bothered adding a changelog entry as I don't believe this is a user-impacting modification. |
|
Could not find any regressions in my testing. So move it over the 🌈 by-passing the 🌠 to the 🌊 and |
(wait, rainbow at night?)Remove the SelectionMover file entirely as it no longer contains any functionality.
|
Build succeeded. |
|
That is without a doubt the most poetic request to ship I've ever received 💌 Thanks for the review! |
Remove superseded SelectionMover class
The SelectionMover class has been superseded by more flexible combinations of filters, scanners and utils. The replacements bring less dependence on the cursor node for positioning, allowing greater flexibility and re-use.
Removing this code and associated tests performs the final step necessary to close #224. In addition, this eliminates redundant line detection logic, so #225 is also closed by this as well.