feat: content claims reads by default with fallback for old index sources #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
approved these changes
Dec 6, 2023
test/index.spec.js
Outdated
|
|
||
| const output = new Uint8Array(await res1.arrayBuffer()) | ||
| assert(equals(input[0].content, output)) | ||
| assert.notEqual(claimsService.getCallCount(), 0) |
There was a problem hiding this comment.
You could have a claimsService.resetCallCount() that is called beforeEach and then you could assert on the real value.
|
Waiting on 🟢 light from @olizilla to get this merged and deployed |
vasco-santos
pushed a commit
that referenced
this pull request
Dec 12, 2023
🤖 I have created a release *beep* *boop* --- ## [2.14.0](v2.13.1...v2.14.0) (2023-12-12) ### Features * content claims reads by default with fallback for old index sources ([#93](#93)) ([46dc509](46dc509)) ### Bug Fixes * add guard for missing dudewhere index links ([b3f7188](b3f7188)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes content claims used by default. If no index was found from content claims, the handler is returned wrapped with the old
withIndexerSourcesandwithDagula(old)Alternatively, we could add a new middleware and keep there the old ones. We could inspect in these middlewares if we have a dagula instance already, but I don't think that is a good way to go as we in the future can just drop this fallback