Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of report.Node.WithID and report.Node.WithTopology #836

Closed
paulbellamy opened this issue Jan 18, 2016 · 0 comments
Closed

Remove usage of report.Node.WithID and report.Node.WithTopology #836

paulbellamy opened this issue Jan 18, 2016 · 0 comments
Assignees
@paulbellamy
Labels
tech-debt Unpleasantness that does (or may in future) affect development
Milestone
0.15.0

Comments

@paulbellamy
Copy link
Contributor

From #752.

Big refactor, so pushed to 0.13 release.

Ideally something like:

t := report.MakeTopology("topologyName") // topologies have a name
node := report.MakeNode("nodeID") // nodes require an id
t = t.AddNode(node) // AddNode uses node.ID, and sets node.Topology
@tomwilkie tomwilkie added this to the 0.13.0 milestone Jan 18, 2016
@tomwilkie tomwilkie added the tech-debt Unpleasantness that does (or may in future) affect development label Jan 28, 2016
@tomwilkie tomwilkie modified the milestones: 0.14.0, 0.13.0 Feb 23, 2016
@tomwilkie tomwilkie removed this from the 0.14.0 milestone Mar 17, 2016
@tomwilkie tomwilkie mentioned this issue Mar 24, 2016
Merged
1 task
@paulbellamy paulbellamy mentioned this issue Apr 19, 2016
Merged
@tomwilkie tomwilkie added this to the 0.15.0 milestone Apr 19, 2016
@paulbellamy paulbellamy self-assigned this Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulbellamy paulbellamy

Labels
tech-debt Unpleasantness that does (or may in future) affect development
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
2 participants
@paulbellamy @tomwilkie