Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate simplifying node IDs #734

Closed
paulbellamy opened this issue Dec 8, 2015 · 3 comments
Closed

Investigate simplifying node IDs #734

paulbellamy opened this issue Dec 8, 2015 · 3 comments
Assignees
@paulbellamy
Labels
tech-debt Unpleasantness that does (or may in future) affect development
Milestone
0.14.0

Comments

@paulbellamy
Copy link
Contributor

We have node ids generated in report/id.go and render/id.go, which generate subtly different IDs. It might be possible to simplify the code either by always using the fully-scoped IDs, or by always using the un-scoped IDs.

Needs investigation...
@paulbellamy paulbellamy added the tech-debt Unpleasantness that does (or may in future) affect development label Dec 8, 2015
@paulbellamy
Copy link
Contributor Author

May also be worth investigating using a typed struct for IDs, instead of parsing/encoding them into strings.

@tomwilkie
Copy link
Contributor

@paulbellamy I believe #1204 fixed this.

@tomwilkie tomwilkie added this to the 0.14.0 milestone Apr 11, 2016
@paulbellamy
Copy link
Contributor Author

Fixed it, but not the structs for ids part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulbellamy paulbellamy

Labels
tech-debt Unpleasantness that does (or may in future) affect development
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
2 participants
@paulbellamy @tomwilkie