Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Connections" and "Connection details" seem redundant in the details panel #322

Closed
tomwilkie opened this issue Jul 16, 2015 · 3 comments
Closed
Assignees

Comments

@tomwilkie
Copy link
Contributor

We could merge them, potentially making the details bit expand on demand or something.

@2opremio
Copy link
Contributor

Before I get down to code it, and as suggested by @davkal, here's the sketch of my proposal. Sorry for my shitty photoshop skills:
proposal

The idea is to have expandable tables, which you expand by clicking on the + button (and collapse again by pressing the - button). We can do this in two steps in order to avoid involving @davkal right away since he has more important stuff on his plate.

  1. Merge the Connection Details table into the Connections table and mark the Connection Details rows as expandable (I will add a row attribute for this). @davkal can simply start by ignoring this attribute (which I would guess that's what the code does right now) resulting in all the Connection rows being expanded without any changes to the frontend.
  2. As soon as @davkal has the time he can add the table expansion to the UI by checking the expandable attribute of the rows.

@tomwilkie @davkal Thoughts?

@tomwilkie
Copy link
Contributor Author

I like this proposal. When you do the merge, can you move the connections table to the bottom (until its expandable).

For the expandability icon, an upside-down pyramid might be more fitting with material design. I'll leave that up to david.

@2opremio
Copy link
Contributor

Yep, I didn't know about the guide until now. It does cover list Expand/collapse and it unsurprisingly looks better than my sketch :)

Ok, I will get down to code it then and I will move it to the bottom while at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants