Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking pause doesn't freeze Node Details data #2658

Closed
fbarl opened this issue Jun 28, 2017 · 0 comments · Fixed by #2651
Closed

Clicking pause doesn't freeze Node Details data #2658

fbarl opened this issue Jun 28, 2017 · 0 comments · Fixed by #2651
Assignees
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer

Comments

@fbarl
Copy link
Contributor

fbarl commented Jun 28, 2017

From Slack:

matthias [3:27 PM]
when hitting 'pause' in scope in dev I still see things moving in the details panel, e.g. metrics are changing. I thought this should all be looking at a specific point in time?

filip
[3:32 PM]
...what's happening is that clicking pause stops updating the nodes through websockets (those deltas are buffered in the UI), but when node details are open, there are additional periodic requests to the API being made for that node and we aren't pausing those..

Proper solution would require using updatePausedAt timestamp when querying the API for node details info, but currently that timestamp is always calculated from the timeTravelMillisecondsInPast value. Once #2651 is merged, fixing this will be much simpler as only one source of truth will be used.

@fbarl fbarl added bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer labels Jun 28, 2017
@fbarl fbarl self-assigned this Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant