Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeSummaryGroupSpec looks wrong #2630

Closed
rade opened this issue Jun 21, 2017 · 1 comment
Closed

nodeSummaryGroupSpec looks wrong #2630

rade opened this issue Jun 21, 2017 · 1 comment
Assignees
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality

Comments

@rade
Copy link
Member

rade commented Jun 21, 2017

The nodeSummaryGroupSpec looks wrong. AFAICT the data is (only) used to display children in the details panel. But several of the included items cannot be children of anything: Hosts, K8S Services, ECS Services.

For a moment I thought that perhaps it's a "list of all the things", but Deployments and DaemonSets aren't in it.

@2opremio @ekimekim Am I misunderstanding the purpose of this list?

@rade rade added the chore Related to fix/refinement/improvement of end user or new/existing developer functionality label Jun 21, 2017
@ekimekim
Copy link
Contributor

I concur. We should either ensure everything is in the list, or delete anything that isn't needed and is unlikely to ever be needed. My preference is the latter, especially since there's fallback code that presents a sane default if one is missing.

@rade rade self-assigned this Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality
Projects
None yet
Development

No branches or pull requests

2 participants