Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popped out terminal window gets stuck #2502

Closed
abuehrle opened this issue May 7, 2017 · 24 comments
Closed

Popped out terminal window gets stuck #2502

abuehrle opened this issue May 7, 2017 · 24 comments
Assignees
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Milestone

Comments

@abuehrle
Copy link
Contributor

abuehrle commented May 7, 2017

Browser: Chrome 57.0.2987.133 (64-bit)
Version: VERSIONc897c188 ON service

(The .JSON report is attached as a txt)

Doing a grep on the system and then popping out the terminal causes white, empty screen (frozen):

screen shot 2017-05-07 at 11 32 55 am

Yet processes are still running looking at the CPU:

screen shot 2017-05-07 at 11 35 35 am

Grep-popping-out-window.txt

@abuehrle abuehrle added the bug Broken end user or developer functionality; not working as the developers intended it label May 7, 2017
@2opremio
Copy link
Contributor

2opremio commented May 8, 2017

@abuehrle Is it reproducible? Was it a host terminal? Did you pop out the terminal while the command was running?

@abuehrle
Copy link
Contributor Author

abuehrle commented May 8, 2017

I was running a command, but I saw the same behaviour without running a command. I will invite you to the instance.

You're already in the instance: https://cloud.weave.works/org/cold-hill-34/

@abuehrle
Copy link
Contributor Author

abuehrle commented May 8, 2017

Yes it was on a host terminal (on the Master node).

@abuehrle
Copy link
Contributor Author

This is still a problem. The terminal is not re-initializing when you pop it out and only does so when you hit return:

http://recordit.co/wJWaXtjT3B

@2opremio 2opremio added the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label May 24, 2017
@2opremio 2opremio added this to the Next milestone May 24, 2017
@2opremio
Copy link
Contributor

I think that the UI should save the terminal buffer and copy it to the pop-up when detaching the window.

@abuehrle
Copy link
Contributor Author

abuehrle commented Jun 22, 2017

I am also seeing this when popping out the log terminal:

  1. Chrome (Kubernetes, Sockshop, Digital Ocean, Ubuntu)
  2. Searched for Scope (while filtered on Containers > System Containers >Running Containers > Show uncontained > All Namespaces

I should add here that the cluster has been up for three days.

screen shot 2017-06-22 at 11 40 55 am

@rade
Copy link
Member

rade commented Jul 12, 2017

The terminal window not retaining history when popping out is #2151.

The terminal window "freezing" when popping out would be a bug. @abuehrle next time you see this in an instance, please invite me.

@rade rade changed the title Popping out shell window during a process fails Popped out terminal window gets stuck Jul 12, 2017
@rade rade modified the milestones: 1.6, Next Jul 12, 2017
@abuehrle
Copy link
Contributor Author

This is still occurring when you can get messages to appear. You are in the instance as listed above (cold-hill-34). Now however I am seeing some other behaviour that is new. (I will log a different issue. )

@rade
Copy link
Member

rade commented Jul 12, 2017

This is still occurring when you can get messages to appear.

What is still occurring? The frozen, white terminal window? And what do you mean by "when you can get messages to appear"?

You are in the instance as listed above (cold-hill-34)

I've successfully popped out both terminal and log windows for a weave scope agent container on that instance. Everything seems to work as expected, modulo #2151.

@abuehrle
Copy link
Contributor Author

The terminal no longer looks frozen, but log messages do not resume when you pop out the window.

There is also an additional problem of when you pop out the terminal and click something on the main screen, the popped out terminal is hidden beneath the browser (I'll log a separate issue for that).

http://recordit.co/5P5LMCUk2v

@rade
Copy link
Member

rade commented Jul 12, 2017

The terminal no longer looks frozen, but log messages do not resume when you pop out the window.

That is definitely a bug.

There is also an additional problem of when you pop out the terminal and click something on the main screen, the popped out terminal is hidden beneath the browser (I'll log a separate issue for that).

That is totally expected behaviour. You've popped out the window; it's now behaves like any other window on your system.

@abuehrle
Copy link
Contributor Author

That is totally expected behaviour. You've popped out the window; it's now behaves like any other window on your system.

Filed a new issue for this #2706

@rade
Copy link
Member

rade commented Jul 12, 2017

log messages do not resume when you pop out the window.

That is definitely a bug.

I think that's a separate bug from the "white, frozen" bug described here. AFAICT it only happens for pods, so I suspect some brokenness in the pod log re-attachment logic. Can you reproduce the problem (logs showing fine while not popped out, but not resuming when popped out) for plain containers?

@abuehrle
Copy link
Contributor Author

Can you reproduce the problem (logs showing fine while not popped out, but not resuming when popped out) for plain containers?

Plain containers seem to work fine:

http://recordit.co/sb78X2TYa6

@abuehrle
Copy link
Contributor Author

As a follow up here I left the Kube-api window open for some time, and logs do eventually resume. I opened a new log window on the kube-api and compared the messages and both windows match and are up to date. So this may not be an issue.

@abuehrle
Copy link
Contributor Author

I think this is still an issue and needs investigation. Not sure under what circumstances this fails.

But I have captured a screen shot below that shows the Kube-api logs popped out and a view of the logs not popped out. The popped out version is still 'stuck' and doesn't resume logs (I left it open for about five minutes).

same instance: cold-hill-34

screen shot 2017-07-13 at 11 47 00 am

@abuehrle abuehrle reopened this Jul 13, 2017
@bboreham
Copy link
Collaborator

When I get this issue, if I open Chrome developer tools I see this:

vendors.js?7c5df1b…:1 Uncaught TypeError: Cannot read property 'call' of undefined
    at n (vendors.js?7c5df1b…:1)
    at Object.<anonymous> (terminal-app-7a51cc8….js?7c5df1b…:29)
    at n (vendors.js?7c5df1b…:1)
    at Object.<anonymous> (terminal-app-7a51cc8….js?7c5df1b…:41)
    at n (vendors.js?7c5df1b…:1)
    at window.webpackJsonp (vendors.js?7c5df1b…:1)
    at terminal-app-7a51cc8….js?7c5df1b…:1
n @ vendors.js?7c5df1b…:1
(anonymous) @ terminal-app-7a51cc8….js?7c5df1b…:29
n @ vendors.js?7c5df1b…:1
(anonymous) @ terminal-app-7a51cc8….js?7c5df1b…:41
n @ vendors.js?7c5df1b…:1
window.webpackJsonp @ vendors.js?7c5df1b…:1
(anonymous) @ terminal-app-7a51cc8….js?7c5df1b…:1

@rade
Copy link
Member

rade commented Jul 26, 2017

@foot iirc you said you know what the problem was here.

@foot
Copy link
Contributor

foot commented Jul 26, 2017

Broken on prod:

  • scope@a6d3542c
  • service-ui@b7c93a3

Works on dev:

  • scope@d9705bc6
  • service-ui@3707202

@rade
Copy link
Member

rade commented Jul 26, 2017

The standalone scope on prod works fine for me. Which suggests that this is a service-ui issue.

@foot
Copy link
Contributor

foot commented Jul 26, 2017

Fixed by deploying prod.

Nothing in git log d9705bc6... a6d3542c is an obvious culprit. Maybe some of the transitional npm -> yarn work? Maybe a bad day on circle.

Please re-open this if you see it again.

Other things we could do if this happens again: Add comment header to bundle.js's w/ build details so we can inspect the build that generated them.

@foot foot closed this as completed Jul 26, 2017
@rade rade modified the milestones: Next, 1.6 Jul 28, 2017
@rade
Copy link
Member

rade commented Oct 4, 2017

Bryan and I are both seeing this - blank, frozen window on pop-out - (again) consistently for host terminals in dev-on-prod but not dev-on-dev.

@rade rade reopened this Oct 4, 2017
@foot
Copy link
Contributor

foot commented Oct 4, 2017

ta. yeah, its the scope/(index|terminal).html served up by the scope query service is broken again.

We should move terminal.html into service-ui anyway.

I'm curious as to whats happening w/ the scope build so will have a poke..

@foot
Copy link
Contributor

foot commented Oct 12, 2017

The terminal issue has been fixed by https://github.com/weaveworks/service-ui/pull/1192 and #2882.

The scope build is still probably there, new issue #2889.

@foot foot closed this as completed Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Development

No branches or pull requests

5 participants