-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popped out terminal window gets stuck #2502
Comments
@abuehrle Is it reproducible? Was it a host terminal? Did you pop out the terminal while the command was running? |
I was running a command, but I saw the same behaviour without running a command. I will invite you to the instance. You're already in the instance: https://cloud.weave.works/org/cold-hill-34/ |
Yes it was on a host terminal (on the Master node). |
This is still a problem. The terminal is not re-initializing when you pop it out and only does so when you hit return: |
I think that the UI should save the terminal buffer and copy it to the pop-up when detaching the window. |
This is still occurring when you can get messages to appear. You are in the instance as listed above (cold-hill-34). Now however I am seeing some other behaviour that is new. (I will log a different issue. ) |
What is still occurring? The frozen, white terminal window? And what do you mean by "when you can get messages to appear"?
I've successfully popped out both terminal and log windows for a weave scope agent container on that instance. Everything seems to work as expected, modulo #2151. |
The terminal no longer looks frozen, but log messages do not resume when you pop out the window. There is also an additional problem of when you pop out the terminal and click something on the main screen, the popped out terminal is hidden beneath the browser (I'll log a separate issue for that). |
That is definitely a bug.
That is totally expected behaviour. You've popped out the window; it's now behaves like any other window on your system. |
Filed a new issue for this #2706 |
I think that's a separate bug from the "white, frozen" bug described here. AFAICT it only happens for pods, so I suspect some brokenness in the pod log re-attachment logic. Can you reproduce the problem (logs showing fine while not popped out, but not resuming when popped out) for plain containers? |
Plain containers seem to work fine: |
As a follow up here I left the Kube-api window open for some time, and logs do eventually resume. I opened a new log window on the kube-api and compared the messages and both windows match and are up to date. So this may not be an issue. |
I think this is still an issue and needs investigation. Not sure under what circumstances this fails. But I have captured a screen shot below that shows the Kube-api logs popped out and a view of the logs not popped out. The popped out version is still 'stuck' and doesn't resume logs (I left it open for about five minutes). same instance: cold-hill-34 |
When I get this issue, if I open Chrome developer tools I see this:
|
@foot iirc you said you know what the problem was here. |
Broken on prod:
Works on dev:
|
The standalone scope on prod works fine for me. Which suggests that this is a service-ui issue. |
Fixed by deploying prod. Nothing in Please re-open this if you see it again. Other things we could do if this happens again: Add comment header to bundle.js's w/ build details so we can inspect the build that generated them. |
Bryan and I are both seeing this - blank, frozen window on pop-out - (again) consistently for host terminals in dev-on-prod but not dev-on-dev. |
ta. yeah, its the scope/(index|terminal).html served up by the scope query service is broken again. We should move terminal.html into service-ui anyway. I'm curious as to whats happening w/ the scope build so will have a poke.. |
The terminal issue has been fixed by https://github.com/weaveworks/service-ui/pull/1192 and #2882. The scope build is still probably there, new issue #2889. |
Browser: Chrome 57.0.2987.133 (64-bit)
Version: VERSIONc897c188 ON service
(The .JSON report is attached as a txt)
Doing a grep on the system and then popping out the terminal causes white, empty screen (frozen):
Yet processes are still running looking at the CPU:
Grep-popping-out-window.txt
The text was updated successfully, but these errors were encountered: