Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide k8s pause containers from k8s details #2324

Closed
rade opened this issue Mar 11, 2017 · 9 comments
Closed

hide k8s pause containers from k8s details #2324

rade opened this issue Mar 11, 2017 · 9 comments
Assignees
@2opremio
Labels
feature Indicates that issue is related to new end user functionality k8s Pertains to integration with Kubernetes

Comments

@rade
Copy link
Member

rade commented Mar 11, 2017 •
edited
Loading

It is really quite distracting to see the 'pause' processes / 'POD' containers that kubernetes adds to every pod.

A user can already hide them in the container topology by selecting the 'Application Containers' filter. But there is no way to omit them from container and process lists in the detail panels of pods, replica sets, deployments and services.
@rade rade added feature Indicates that issue is related to new end user functionality k8s Pertains to integration with Kubernetes labels Mar 11, 2017
@2opremio 2opremio self-assigned this Mar 16, 2017
@2opremio
Copy link
Contributor

I have given some thought to this and I am not sure we should be treating them so specially (more so than other system containers).

It will feel strange to show them in the container topology (when system containers are enabled) and not show them in the detail panels.

That said, its true that their details don't add anything ...

@2opremio 2opremio mentioned this issue Mar 16, 2017
Merged
@rade
Copy link
Member Author

rade commented Mar 16, 2017

I should have added that I filed this issue based on user feedback (which I happen to agree with ;). Alas I also struggle to work out how exactly to achieve the desired outcome, given that we don't want to always hide the pause containers everywhere.

@2opremio
Copy link
Contributor

I also struggle to work out how exactly to achieve the desired outcome

It's actually much easier than I thought, see #2338

@rade
Copy link
Member Author

rade commented Mar 16, 2017

Right, but does it make sense? Or is it misleading?

@2opremio
Copy link
Contributor

2opremio commented Mar 16, 2017 •
edited
Loading

Uhm, given that pause containers:

  • Consume close to 0 resources
  • Don't explicitly appear on the k8s graph/table view
  • They also get filtered as system containers

I don't think it hurts.

To normalize it, we could add an Application/System selector to the k8s views (like we have in the containers view) but I am not sure it's worth it.

@2opremio
Copy link
Contributor

To normalize it, we could add an Application/System selector to the k8s views (like we have in the containers view) but I am not sure it's worth it.

Note that this would probably conflict with #1423

@rade
Copy link
Member Author

rade commented Mar 16, 2017

I don't think it hurts.

Maybe. We are breaking @davkal's rules from #1864 here though, namely that filters do not apply to detail panels.

@2opremio
Copy link
Contributor

Then we (I) already completely broke it on #1904

@rade
Copy link
Member Author

rade commented Mar 16, 2017

Then we (I) already completely broke it on #1904

on balance, I think I approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2opremio 2opremio

Labels
feature Indicates that issue is related to new end user functionality k8s Pertains to integration with Kubernetes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rade @2opremio