Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throb animation is called on graph nodes even when the search query doesn't change #2255

Closed
fbarl opened this issue Feb 16, 2017 · 0 comments · Fixed by #2291
Closed

Throb animation is called on graph nodes even when the search query doesn't change #2255

fbarl opened this issue Feb 16, 2017 · 0 comments · Fixed by #2291
Assignees
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Milestone

Comments

@fbarl
Copy link
Contributor

fbarl commented Feb 16, 2017

To reproduce (on Chrome):

  1. Open a big topology in graph view mode
  2. Do a broad search query, like "a", without hitting Enter
  3. Hover over some nodes
  4. Observe how a lot of nodes get animated (basically each time after mouse leaves a node)

It's a weird bug because the nodes actually don't get rerendered when they are animated, so the question is why the CSS animations get triggered. I think it has to do with sorting of nodes we do in NodesChartNodes, as the bug is not there when we don't sort them. So permuting the list of DOM elements seems to trigger CSS even when no React rerendering of elements takes place. An obvious fix might be to do the whole animation from JS instead of CSS.

@fbarl fbarl added bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer labels Feb 16, 2017
@2opremio 2opremio modified the milestones: Next, 1.3 Feb 16, 2017
@fbarl fbarl self-assigned this Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants