Incorrect route is used in getAllNodes() call

[jpellizzari]

Moved from weaveworks/service#1053

The leading slash in the topologyUrlsById is causing the incorrect route to be requested.

Repro steps:

1. Within cloud, enter some search terms in scope.
2. JSON.parse() errors will appear in the console, as a result of a call to /api/topology/containers
3. Notice that the cloud index.html file is served instead of a JSON response.

The request to
https://cloud.weave.works/api/topology/containers
should be
https://cloud.weave.works/api/app/loud-breeze-77/api/topology/containers

[rade]

What functionality, if any, does this break? Search seems to work fine in Weave Cloud.

[jpellizzari]

Searching triggers a fetch of topologies which is throwing errors in the console. The search functionality itself seems to still work, since it does not rely on the result of the fetch. I'm not sure why searching needs to trigger that request, but its not working.

[rade]

I'm not sure why searching needs to trigger that request,

This is worth investigating.

[jpellizzari]

@rade Found it!:

    dispatch({ type: ActionTypes.FOCUS_SEARCH });
    // update nodes cache to allow search across all topologies,
    // wait a second until animation is over
    setTimeout(() => {
      getAllNodes(getState, dispatch);
    }, 1200);

We discussed a possible improvement in our cloud-prod sync today. I documented it here: https://github.com/weaveworks/service-conf/issues/500

[jpellizzari]

Closed by #2124