Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for the ECS reporter #2036

Closed
2opremio opened this issue Nov 29, 2016 · 2 comments
Closed

Add unit tests for the ECS reporter #2036

2opremio opened this issue Nov 29, 2016 · 2 comments
Assignees
Labels
component/build An issue concerning compilation, testing, packaging, distribution ecs Pertains to integration with Amazon Elastic Container Service tech-debt Unpleasantness that does (or may in future) affect development
Milestone

Comments

@2opremio
Copy link
Contributor

Leftover from #2026

@2opremio 2opremio added the chore Related to fix/refinement/improvement of end user or new/existing developer functionality label Nov 29, 2016
@2opremio 2opremio added this to the November2016 milestone Nov 29, 2016
@2opremio 2opremio mentioned this issue Nov 29, 2016
9 tasks
@2opremio
Copy link
Contributor Author

2opremio commented Nov 29, 2016

Fixing this should include addressing the following TODO:

		// TODO: add ECS nodes in report fixture
		if topology.Name == "Tasks" {
			continue
		}

// TODO: add ECS nodes in report fixture
if topology.Name == "Tasks" {
continue
}

@2opremio 2opremio modified the milestones: December2016, Backlog Dec 5, 2016
@2opremio 2opremio added the ecs Pertains to integration with Amazon Elastic Container Service label Dec 12, 2016
@2opremio 2opremio modified the milestones: December2016, EOY 2016 Dec 13, 2016
@rade rade added tech-debt Unpleasantness that does (or may in future) affect development component/build An issue concerning compilation, testing, packaging, distribution and removed chore Related to fix/refinement/improvement of end user or new/existing developer functionality labels Jan 11, 2017
@ekimekim
Copy link
Contributor

fixed by #2065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build An issue concerning compilation, testing, packaging, distribution ecs Pertains to integration with Amazon Elastic Container Service tech-debt Unpleasantness that does (or may in future) affect development
Projects
None yet
Development

No branches or pull requests

3 participants