Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutable defaults for many Grafanalib attributes #105

Closed
jml opened this issue Jan 11, 2018 · 0 comments
Closed

Mutable defaults for many Grafanalib attributes #105

jml opened this issue Jan 11, 2018 · 0 comments
Labels
release-blocker

Comments

@jml
Copy link
Contributor

jml commented Jan 11, 2018

Lots of the attributes in grafanalib have mutable defaults. (e.g. [] or some other grafanalib value). See http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments for why this is a bad idea.

Instead of using empty list, or grafanalib classes, we should use attr.Factory.
@jml jml self-assigned this Jan 11, 2018
@jml jml removed their assignment Jan 11, 2018
@jml jml added this to the 1.0 milestone Jan 11, 2018
@jml jml mentioned this issue Feb 26, 2018
Merged
@jml jml closed this as completed in #114 Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release-blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jml