Skip to content

Commit 03d241a

Browse files
authored
fix: extend constructor options types to allow additional properties (#925)
* this will allow TypeScript users to use request parameters like the `axios` config properties. we support these in the code but not in the types * bump core version to 0.3.4: this version includes the corresponding changes for allowing additional properties in the base service constructor
1 parent 321d080 commit 03d241a

File tree

15 files changed

+33
-7
lines changed

15 files changed

+33
-7
lines changed

assistant/v1.ts

+2
Original file line numberDiff line numberDiff line change
@@ -3289,6 +3289,8 @@ namespace AssistantV1 {
32893289
disable_ssl_verification?: boolean;
32903290
use_unauthenticated?: boolean;
32913291
headers?: OutgoingHttpHeaders;
3292+
/** Allow additional request config parameters */
3293+
[propName: string]: any;
32923294
}
32933295

32943296
export interface Response<T = any> {

assistant/v2.ts

+2
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,8 @@ namespace AssistantV2 {
288288
disable_ssl_verification?: boolean;
289289
use_unauthenticated?: boolean;
290290
headers?: OutgoingHttpHeaders;
291+
/** Allow additional request config parameters */
292+
[propName: string]: any;
291293
}
292294

293295
export interface Response<T = any> {

authorization/v1.ts

+2
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ namespace AuthorizationV1 {
100100
url?: string;
101101
iam_apikey?: string;
102102
iam_url?: string;
103+
/** Allow additional request config parameters */
104+
[propName: string]: any;
103105
}
104106

105107
export interface GetTokenResponse {

compare-comply/v1.ts

+2
Original file line numberDiff line numberDiff line change
@@ -906,6 +906,8 @@ namespace CompareComplyV1 {
906906
disable_ssl_verification?: boolean;
907907
use_unauthenticated?: boolean;
908908
headers?: OutgoingHttpHeaders;
909+
/** Allow additional request config parameters */
910+
[propName: string]: any;
909911
}
910912

911913
export interface Response<T = any> {

discovery/v1.ts

+2
Original file line numberDiff line numberDiff line change
@@ -4178,6 +4178,8 @@ namespace DiscoveryV1 {
41784178
disable_ssl_verification?: boolean;
41794179
use_unauthenticated?: boolean;
41804180
headers?: OutgoingHttpHeaders;
4181+
/** Allow additional request config parameters */
4182+
[propName: string]: any;
41814183
}
41824184

41834185
export interface Response<T = any> {

language-translator/v3.ts

+2
Original file line numberDiff line numberDiff line change
@@ -776,6 +776,8 @@ namespace LanguageTranslatorV3 {
776776
disable_ssl_verification?: boolean;
777777
use_unauthenticated?: boolean;
778778
headers?: OutgoingHttpHeaders;
779+
/** Allow additional request config parameters */
780+
[propName: string]: any;
779781
}
780782

781783
export interface Response<T = any> {

natural-language-classifier/v1.ts

+2
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,8 @@ namespace NaturalLanguageClassifierV1 {
420420
disable_ssl_verification?: boolean;
421421
use_unauthenticated?: boolean;
422422
headers?: OutgoingHttpHeaders;
423+
/** Allow additional request config parameters */
424+
[propName: string]: any;
423425
}
424426

425427
export interface Response<T = any> {

natural-language-understanding/v1.ts

+2
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,8 @@ namespace NaturalLanguageUnderstandingV1 {
287287
disable_ssl_verification?: boolean;
288288
use_unauthenticated?: boolean;
289289
headers?: OutgoingHttpHeaders;
290+
/** Allow additional request config parameters */
291+
[propName: string]: any;
290292
}
291293

292294
export interface Response<T = any> {

package-lock.json

+6-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
"axios": "^0.18.0",
8787
"dotenv": "^6.2.0",
8888
"extend": "~3.0.2",
89-
"ibm-cloud-sdk-core": "^0.3.3",
89+
"ibm-cloud-sdk-core": "^0.3.4",
9090
"isstream": "~0.1.2",
9191
"object.pick": "~1.3.0",
9292
"snyk": "^1.192.4",

personality-insights/v3.ts

+2
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,8 @@ namespace PersonalityInsightsV3 {
332332
disable_ssl_verification?: boolean;
333333
use_unauthenticated?: boolean;
334334
headers?: OutgoingHttpHeaders;
335+
/** Allow additional request config parameters */
336+
[propName: string]: any;
335337
}
336338

337339
export interface Response<T = any> {

speech-to-text/v1-generated.ts

+2
Original file line numberDiff line numberDiff line change
@@ -3509,6 +3509,8 @@ namespace SpeechToTextV1 {
35093509
disable_ssl_verification?: boolean;
35103510
use_unauthenticated?: boolean;
35113511
headers?: OutgoingHttpHeaders;
3512+
/** Allow additional request config parameters */
3513+
[propName: string]: any;
35123514
}
35133515

35143516
export interface Response<T = any> {

text-to-speech/v1-generated.ts

+2
Original file line numberDiff line numberDiff line change
@@ -1166,6 +1166,8 @@ namespace TextToSpeechV1 {
11661166
disable_ssl_verification?: boolean;
11671167
use_unauthenticated?: boolean;
11681168
headers?: OutgoingHttpHeaders;
1169+
/** Allow additional request config parameters */
1170+
[propName: string]: any;
11691171
}
11701172

11711173
export interface Response<T = any> {

tone-analyzer/v3.ts

+2
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,8 @@ namespace ToneAnalyzerV3 {
266266
disable_ssl_verification?: boolean;
267267
use_unauthenticated?: boolean;
268268
headers?: OutgoingHttpHeaders;
269+
/** Allow additional request config parameters */
270+
[propName: string]: any;
269271
}
270272

271273
export interface Response<T = any> {

visual-recognition/v3.ts

+2
Original file line numberDiff line numberDiff line change
@@ -706,6 +706,8 @@ namespace VisualRecognitionV3 {
706706
disable_ssl_verification?: boolean;
707707
use_unauthenticated?: boolean;
708708
headers?: OutgoingHttpHeaders;
709+
/** Allow additional request config parameters */
710+
[propName: string]: any;
709711
}
710712

711713
export interface Response<T = any> {

0 commit comments

Comments
 (0)