Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use mock puller and mounter in the node server tests #83

Merged
merged 4 commits into from
Feb 14, 2024
Merged

test: use mock puller and mounter in the node server tests #83

merged 4 commits into from
Feb 14, 2024

Conversation

vadasambar
Copy link
Contributor

  • makes the tests easier to run
  • edit docs to run node server with containerd image

@vadasambar vadasambar mentioned this pull request Dec 13, 2023
Closed
@vadasambar
Copy link
Contributor Author

@mugdha-adhav @kitt1987 can I get a review on this when you find time 🙏

I am dependent on this PR to test changes in #81

@vadasambar vadasambar mentioned this pull request Dec 14, 2023
Closed
@vadasambar vadasambar requested a review from a team as a code owner January 4, 2024 06:01
@vadasambar
Copy link
Contributor Author

@mugdha-adhav @kitt1987 can I get a review on this 🙏

@vadasambar
Copy link
Contributor Author

@mugdha-adhav @kitt1987 can I get a review on this please 🙏

mbtamuli
mbtamuli reviewed Jan 20, 2024
View reviewed changes
@vadasambar vadasambar mentioned this pull request Feb 2, 2024
Open
mugdha-adhav
mugdha-adhav reviewed Feb 3, 2024
View reviewed changes
@mugdha-adhav mugdha-adhav added the awaiting-inputs Further information is requested label Feb 3, 2024
@vadasambar
test: use mock puller and mounter in the node server tests
05ae0ed 
- makes the tests easier to run
- edit docs to run node server with containerd image

refactor: remove commented out code

chore: switch over from criapi `v1alpha2` -> `v1`
@vadasambar
chore: fix import path name csi-driver-image -> `container-image-cs…
ae12457 
…i-driver`
@vadasambar
docs: replace warm metal -> container-image-csi-driver
07f6953
@vadasambar
test: fix socket path /tmp/csi/csi.sock -> /tmp/csi.sock
9ef0d67
@vadasambar
Copy link
Contributor Author

@mugdha-adhav I have addressed the comments. Can you please review this again 🙏

@mugdha-adhav mugdha-adhav merged commit 82d2e85 into warm-metal:main Feb 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbtamuli mbtamuli mbtamuli approved these changes

@mugdha-adhav mugdha-adhav mugdha-adhav approved these changes

Assignees

@vadasambar vadasambar

Labels
awaiting-inputs Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vadasambar @mbtamuli @mugdha-adhav