Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logo #80

Merged
merged 4 commits into from
Feb 15, 2024
Merged

chore: add logo #80

merged 4 commits into from
Feb 15, 2024

Conversation

vadasambar
Copy link
Contributor

@vadasambar vadasambar commented Dec 8, 2023

Check the logo/README.md for more info.

@@ -1,10 +1,18 @@

<p align="center" width="100%">

This comment was marked as outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(updated logo)
This is what it looks like in the README:
image

@vadasambar
Copy link
Contributor Author

@kitt1987, @mugdha-adhav I thought it would be nice to have a logo for the project.

@vadasambar
Copy link
Contributor Author

vadasambar commented Dec 8, 2023

I think a logo would add more legitimacy to the project. Eventually, I would like for us to pitch including this project under sig-storage so that we can get more eyes on the project.

@kitt1987
Copy link
Contributor

Warm Metal is only a group name, maybe a company name in the future. I guess we can give this project an intuitive name, as well as its logo.

@mugdha-adhav
Copy link
Collaborator

Warm Metal is only a group name, maybe a company name in the future. I guess we can give this project an intuitive name, as well as its logo.

Few naming suggestions -

  1. image-mounter-csi-driver
  2. mountable-image-csi-driver
  3. runtime-image-csi-driver
  4. warm-image-csi-driver
  5. warmify-image-csi-driver

I think we should use csi-driver suffix as it's already being used by multiple major CSI drivers.

@ethan-gallant
Copy link

ethan-gallant commented Dec 16, 2023

Warm Metal is only a group name, maybe a company name in the future. I guess we can give this project an intuitive name, as well as its logo.

Few naming suggestions -

  1. image-mounter-csi-driver
  2. mountable-image-csi-driver
  3. runtime-image-csi-driver
  4. warm-image-csi-driver
  5. warmify-image-csi-driver

I think we should use csi-driver suffix as it's already being used by multiple major CSI drivers.

oci-csi-driver makes sense to me as it plays into the shorthand of open-container-initiative - container-stroage-interface - driver

Or OCI-CSI for short 🚀 :)

@vadasambar
Copy link
Contributor Author

vadasambar commented Dec 18, 2023

  1. image-mounter-csi-driver

+1 to this. It is easy to understand what the driver is doing just by reading the name. I think people might google this more often than oci-csi-driver (another name I like).

@vadasambar
Copy link
Contributor Author

Warm Metal is only a group name, maybe a company name in the future. I guess we can give this project an intuitive name, as well as its logo.

Since I have already made the logo, if you like it, feel free to use it for your organization. I can change the license if you want. We can make another logo for csi-driver-image repo.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jan 18, 2024
@mugdha-adhav
Copy link
Collaborator

@vadasambar now that we have finalized the repository name to container-image-csi-driver, any suggestion on whether we should use the same logo or create a new one?

@vadasambar
Copy link
Contributor Author

@vadasambar now that we have finalized the repository name to container-image-csi-driver, any suggestion on whether we should use the same logo or create a new one?

The logo is based on the ""warm metal" concept. container-image-csi-driver could use a new logo. "warm metal" could be used for the org if @kitt1987 wants to.

@ethan-gallant
Copy link

@vadasambar now that we have finalized the repository name to container-image-csi-driver, any suggestion on whether we should use the same logo or create a new one?

I'm definitely not who you're asking but I wanted to share my two cents.

I think the logo linked (despite being for a previous name) is simple and easily recognizable. It also is nice to have a relic from the history of the product even if that name is no longer in use.

Changing too much at once can be overwhelming so I'm still a fan of the old image :)

@vadasambar
Copy link
Contributor Author

@vadasambar now that we have finalized the repository name to container-image-csi-driver, any suggestion on whether we should use the same logo or create a new one?

I'm definitely not who you're asking but I wanted to share my two cents.

I think the logo linked (despite being for a previous name) is simple and easily recognizable. It also is nice to have a relic from the history of the product even if that name is no longer in use.

Changing too much at once can be overwhelming so I'm still a fan of the old image :)

Thank you for the kind words :')

I'm happy to have that logo represent the driver. That being said, I do see Kitt's point as well. If he decides to build a brand out of it in the future, the brand logo might overlap with the driver logo and add to the confusion.

@kitt1987
Copy link
Contributor

Thanks, guys, also @ethan-gallant. The original logo is OK to me. Just replace 'Warm Metal' with the new repo name if you guys don't mind.

@vadasambar
Copy link
Contributor Author

vadasambar commented Jan 31, 2024

Vote for your favorite by reacting with 👍

@vadasambar
Copy link
Contributor Author

image

@vadasambar
Copy link
Contributor Author

image

@vadasambar
Copy link
Contributor Author

image

@vadasambar
Copy link
Contributor Author

Vote for your favorite by reacting with 👍

@ethan-gallant , @mugdha-adhav , @mbtamuli , @kitt1987 and everyone else.

@vadasambar
Copy link
Contributor Author

vadasambar commented Jan 31, 2024

I will keep the voting open until end of this next week (Friday, 2nd 9th February 6:30 PM UTC / 12:00 AM India Time / 1:30 PM Eastern Time / 2:30 AM China Time). If there are no votes, I will go ahead with the third option.

@mbtamuli
Copy link
Contributor

I don't know what's the font being used. But the g in image seems weird.

@ethan-gallant
Copy link

I will keep the voting open until end of this next week (Friday, 2nd 9th February 6:30 PM UTC / 12:00 AM India Time / 1:30 PM Eastern Time / 2:30 AM China Time). If there are no votes, I will go ahead with the third option.

Thought I was the only one who saw that, I think it may just be a strange font. Possibly downsizing the font size of the g ~2px may help blend it in.

@vadasambar
Copy link
Contributor Author

vadasambar commented Feb 14, 2024

2 is the clear winner.

Here's what 2 with fixed g looks like
image

@vadasambar vadasambar requested a review from a team as a code owner February 14, 2024 17:35
@vadasambar
Copy link
Contributor Author

Here's what it looks like in the README:
image

@mugdha-adhav mugdha-adhav merged commit 3d36010 into warm-metal:main Feb 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants