fix: redact sensitive fields when printing grpc request #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vadasambar could you please paste an output of how the log messages are printed after this change? |
https://github.com/vadasambar/protosanitizer-poc Does this help? |
Yeah, looks good. As we are also using klog, I would expect similar results in the logging behaviour. |
|
If you need a release for this change, I would suggest to update Chart.yaml and Makefile with new version to avoid another commit/PR. |
mugdha-adhav
approved these changes
May 8, 2024
|
@mugdha-adhav thanks. I have updated the Makefile and Chart.yaml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps prevent sensitive information in the requests from leaking out in the logs.