Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logo is not getting loaded on the README #146

Closed
mugdha-adhav opened this issue Feb 15, 2024 · 6 comments
Closed

New logo is not getting loaded on the README #146

mugdha-adhav opened this issue Feb 15, 2024 · 6 comments
Labels
good-first-issue Good for newcomers Stale

Comments

@mugdha-adhav
Copy link
Collaborator

We recently added a logo for our repository in #80.

After we merged the PR, the logo is not loading for me on the README.

Screenshot 2024-02-15 at 8 27 07 PM
@mugdha-adhav mugdha-adhav added the good-first-issue Good for newcomers label Feb 15, 2024
@mbtamuli
Copy link
Contributor

Ah, I noticed I can see the logo when I'm not on dark mode on my system.

image

Dark mode causes the logo to not show up.

@mbtamuli
Copy link
Contributor

I found the issue -

<source media="(prefers-color-scheme: dark)" srcset="./logo/aqua_horizontal_white.svg">

The dark mode calls a file that doesn't exist.

@mugdha-adhav
Copy link
Collaborator Author

mugdha-adhav commented Feb 15, 2024

The logo would look something like this after getting rendered in the dark mode -

Screenshot 2024-02-16 at 3 19 31 AM

Any suggestions on do we want a different colour scheme in the logo for dark mode?

@mbtamuli
Copy link
Contributor

do we want a different colour scheme in the logo for dark mode?

Maybe we can move this to a discussion? So we keep this issue crisp and ready for anyone getting started on the repository as a good-first-issue.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label May 17, 2024
Copy link

github-actions bot commented Jun 1, 2024

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers Stale
Projects
None yet
Development

No branches or pull requests

2 participants