Clean up external message protocol #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtfmumm
force-pushed
the
external-cleanup
branch
from
6362976 to
c5e248b
Compare
|
These changes are transparent to users of the ExternalMsgEncoder and ExternalMsgDecoder (and are related to the same unit tests which exercise the related methods), except the removed message types, which weren't being used anywhere. |
jtfmumm
force-pushed
the
external-cleanup
branch
from
c5e248b to
f3d0532
Compare
* Remove unused message types (which were the majority) and related code. * Standardize all ExternalMsg protocols into the simplest one. * Add json encoders and decoders for shrink external messages. * Update ExternalMsgEncoder/Decoder to use the simple external message protocol with json payloads for shrink messages.
jtfmumm
force-pushed
the
external-cleanup
branch
from
f3d0532 to
30d66c0
Compare
slfritchie
approved these changes
Feb 5, 2018
|
@slfritchie Currently it wouldn't because it doesn't ignore spaces, and really all the JSON decoding/encoding will need improvement. I'll open an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and related code.
message protocol with json payloads for shrink messages.
Closes #2031