-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "name()" from StateBuilder interface #1988
Conversation
@aturley I've put you on this PR because it's mostly changes to the Python and Go APIs as well as related examples. The core changes are removing |
Given that this is completely invisible to end users, I think the CHANGELOG label can be removed. There's no need for this to be in the CHANGELOG. |
@SeanTAllen This required changes to the Go and Pony example apps since it removed the requirement for |
Ah, ok. This is however, a non-breaking change, correct? and it seems to have not been updated for the new API. |
@SeanTAllen This is a non-breaking change. I don't see what I missed in that document you linked to. |
1bc16ef
to
2a5dfcf
Compare
We don't currently use the StateBuilder name for any reason and it creates more boilerplate when creating stateful apps. This removes name() from the interface and updates Python and Go APIs as well as example apps and book examples accordingly. Instead of the StateBuilder name, we now use the state partition name, which would do the trick if we ever end up needing it for logging purposes. [skip ci] Closes #1809
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
We don't currently use the StateBuilder name for any
reason and it creates more boilerplate when creating
stateful apps. This removes name() from the interface
and updates Python and Go APIs as well as example
apps and book examples accordingly. Instead of the
StateBuilder name, we now use the state partition
name, which would do the trick if we ever end up
needing it for logging purposes.
Closes #1809