New version of Python API based on decorators #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aturley
approved these changes
Jan 2, 2018
aturley
reviewed
Jan 2, 2018
|
|
||
| `payload_length` is used to decode our message header to determine how long the payload is going to be. In this case, we are relying on the Python `struct` package to decode the bytes. If you aren't familiar with `struct`, you can check out [the documentation](https://docs.python.org/2/library/struct.html) to learn more. Remember, when using `struct`, don't forget to import it! | ||
| `fmt` is used internally to decode our message header to determine how long the payload is going to be. We rely on the Python `struct` package to decode the bytes. If you aren't familiar with `struct`, you can check out [the documentation](https://docs.python.org/2/library/struct.html) to learn more. Remember, when using `struct`, don't forget to import it! |
There was a problem hiding this comment.
Should be length_fmt, not fmt.
aturley
reviewed
Jan 2, 2018
machida/wallaroo.py
Outdated
| class TCPSourceConfig(object): | ||
| def __init__(self, host, port, decoder): |
There was a problem hiding this comment.
Somehow decoders and encoders got switch around here and in TCPSinkConfig.
aturley
reviewed
Jan 2, 2018
machida/wallaroo.py
Outdated
| class TCPSourceConfig(object): | ||
| def __init__(self, host, port, decoder): | ||
| def __init__(self, host, port, encoder): |
aturley
reviewed
Jan 2, 2018
machida/wallaroo.py
Outdated
| self._host = host | ||
| self._port = port | ||
| self._decoder = decoder | ||
| self._encoder = encoder |
aturley
reviewed
Jan 2, 2018
machida/wallaroo.py
Outdated
|
|
||
| def to_tuple(self): | ||
| return ("tcp", self._host, self._port, self._decoder) | ||
| return ("tcp", self._host, self._port, self._encoder) |
aturley
reviewed
Jan 2, 2018
machida/wallaroo.py
Outdated
|
|
||
|
|
||
| class TCPSinkConfig(object): | ||
| def __init__(self, host, port, encoder): | ||
| def __init__(self, host, port, decoder): |
aturley
reviewed
Jan 2, 2018
machida/wallaroo.py
Outdated
| self._host = host | ||
| self._port = port | ||
| self._encoder = encoder | ||
| self._decoder = decoder |
aturley
reviewed
Jan 2, 2018
machida/wallaroo.py
Outdated
|
|
||
| def to_tuple(self): | ||
| return ("tcp", self._host, self._port, self._encoder) | ||
| return ("tcp", self._host, self._port, self._decoder) |
aturley
suggested changes
Jan 2, 2018
nitbix
force-pushed
the
new-python-api
branch
2 times, most recently
from
8c3b5c3 to
983f74f
Compare
nitbix
changed the title
| return ab.build() | ||
|
|
||
| @wallaroo.computation_multi(name="split into words") |
There was a problem hiding this comment.
You need another newline before this for PEP8 compatibility
aturley
reviewed
Jan 4, 2018
machida/wallaroo.py
Outdated
| @@ -79,13 +79,16 @@ def build(self): | |||
|
|
|||
|
|
|||
| def computation(name): | |||
| print 'computation', name | |||
There was a problem hiding this comment.
This doesn't need to be here does it?
There was a problem hiding this comment.
Ah good catch! Thanks!
nisanharamati
force-pushed
the
new-python-api
branch
from
f750365 to
0d4d7f7
Compare
|
@SeanTAllen @nitbix @aturley |
The Python API was using a ''class-based'' approach that was very similar to the C++ API. This wasn't very pythonic, so this change adds decorators in place of a lot of the boiler-plate classes and builders we were using. This results in shorter application code, and less responsibility on the developer to respect Wallaroo interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking API change, so I've made this speculative PR while I prepare all the changes to examples and documentation so that we can start discussing potential other changes to the API.