Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent IDL naming: aggregationServices vs aggregators #66

Open
apasel422 opened this issue Jan 14, 2025 · 1 comment · May be fixed by #67
Open

Inconsistent IDL naming: aggregationServices vs aggregators #66

apasel422 opened this issue Jan 14, 2025 · 1 comment · May be fixed by #67
Labels
discuss Needs working group discussion

Comments

@apasel422
Copy link
Contributor

The IDL defines aggregators, but the text refers to aggregationServices.
apasel422 added a commit to apasel422/ppa-api that referenced this issue Jan 14, 2025
@apasel422
Rename PrivateAttribution.aggregators to aggregationServices
6d95d6e 
To match the surrounding prose, and for consistency with the names of
the corresponding IDL types.

Fixes w3c#66
@apasel422 apasel422 linked a pull request Jan 14, 2025 that will close this issue
Open
@martinthomson martinthomson added the discuss Needs working group discussion label Jan 29, 2025
@martinthomson
Copy link
Member

This is a wonderful issue to spend meeting time on!

I generally have a strong preference for shorter names where they make sense. Andy suggested that maybe we could make the opposite change to that proposed in #67, which might work out. Suggestions thus far:

  • Aggregation service
  • Aggregator
  • (something else?)

apasel422 added a commit to apasel422/ppa-api that referenced this issue Jan 30, 2025
@apasel422
Rename PrivateAttribution.aggregators to aggregationServices
24da8cd 
To match the surrounding prose, and for consistency with the names of
the corresponding IDL types.

Fixes w3c#66
@martinthomson martinthomson moved this to Important in PPA API, Level 1 Feb 3, 2025
@martinthomson martinthomson moved this from Important to Nice to have in PPA API, Level 1 Feb 3, 2025
@martinthomson martinthomson closed this as completed by moving to Nice to have in PPA API, Level 1 Feb 3, 2025
@martinthomson martinthomson reopened this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss Needs working group discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename PrivateAttribution.aggregators to aggregationServices apasel422/ppa-api
2 participants
@martinthomson @apasel422