-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Open in Codepen" button to Treegrid example #1694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Approving now, even though it can't be merged until the cspell ignore regex is fixed.
@nschonni Is the following regex correct?
"url\\(\"data\\:image/svg\\+xml.*\"\\)[,;]"
@carmacleod makes sense to me, or the punctuation could possibly be dropped entirely. I was just trying to make sure the regex didn't get to greedy, but maybe that's not really an issue for this |
Thank-you, @nschonni - I created #1696 to add I have no idea how to test whether merging 1696 will allow this PR to pass the spell-check. (but I think it should work...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ... this would have been a perfect opportunity to improve how we set aria-current. I think it should be on the link inside the list item, not on the entire list item. Rendering aria-current on a long item is awkward for screen readers. I'll raise a separate issue for that though. I want to get this merged.
Adding the open in Codepen button! This involved moving some SVGs and moving some code.
Preview