Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove or rename tests #1444

Open
mcking65 opened this issue Jul 13, 2020 · 2 comments
Open

Can't remove or rename tests #1444

mcking65 opened this issue Jul 13, 2020 · 2 comments
Assignees
Labels
question Issue asking a question regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo

Comments

@mcking65
Copy link
Contributor

Review comments about test merge conflicts in 1356.

We seem to get caught in a loop when trying to remove a test file. PR 1356 originally moved the editor menubar example up one level in the directory structure and renamed it. Jon tried to adjust the tests in the same PR, but doing so either resulted in a state where there were merge conflicts or a state where tests failed.

Our current work around is:

  1. Instead of move/rename of the example, PR 1356 now creates a new version, leaving existing the same.
  2. After we merge the new, make a PR to delete the old.

Is this how it must be done to get through CI? When PR 1356 was first created, it did a move/rename and the tests were passing and there were no merge conflicts. So, it does seem like has something has changed, but we don't know what.

@mcking65 mcking65 added question Issue asking a question regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo labels Jul 13, 2020
@spectranaut
Copy link
Contributor

I looked into this for a moment, but it's really hard to follow a long, because there are so many adds and deletes and restarted builds. Can we try deleting the renamed files in #1359 so I can see what the failure is there, and if it's repeatable or something unique to #1356?

@a11ydoer
Copy link
Contributor

I looked into this for a moment, but it's really hard to follow a long, because there are so many adds and deletes and restarted builds. Can we try deleting the renamed files in #1359 so I can see what the failure is there, and if it's repeatable or something unique to #1356?

This method may also help to check correct folder structure relationship with testing file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Issue asking a question regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo
Projects
None yet
Development

No branches or pull requests

3 participants