Skip to content

Commit b1e4f2c

Browse files
authored
Infrastructure: Temporarily comment out flaky tests (pull #1488)
Disable a few unreliable regression tests that we don't want to impede other work while we determine the root cause of the inconsistent test behavior. This change comments out tests that fail most frequently in CI. The regression test coverage report will report them as missing. The work to resolve the root issue is tracked by issue #1415.
1 parent 32f0774 commit b1e4f2c

File tree

1 file changed

+45
-40
lines changed

1 file changed

+45
-40
lines changed

test/tests/menu-button_actions-active-descendant.js

+45-40
Original file line numberDiff line numberDiff line change
@@ -277,38 +277,42 @@ ariaTest('"escape" on role="menu"', exampleFile, 'menu-escape', async (t) => {
277277
}
278278
});
279279

280-
ariaTest('"down arrow" on role="menu"', exampleFile, 'menu-down-arrow', async (t) => {
280+
// This test is flaky, so is commented out for now.
281+
// We are traking it in issue:https://github.com/w3c/aria-practices/issues/1415
282+
// ariaTest('"down arrow" on role="menu"', exampleFile, 'menu-down-arrow', async (t) => {
281283

282-
await openMenu(t);
283-
const menu = await t.context.session.findElement(By.css(ex.menuSelector));
284-
const items = await t.context.queryElements(t, ex.menuitemSelector);
284+
// await openMenu(t);
285+
// const menu = await t.context.session.findElement(By.css(ex.menuSelector));
286+
// const items = await t.context.queryElements(t, ex.menuitemSelector);
285287

286-
for (let index = 0; index < items.length - 1; index++) {
288+
// for (let index = 0; index < items.length - 1; index++) {
287289

288-
await menu.sendKeys(Key.ARROW_DOWN);
289-
await assertAriaActivedescendant(t, ex.menuSelector, ex.menuitemSelector, index + 1);
290-
}
290+
// await menu.sendKeys(Key.ARROW_DOWN);
291+
// await assertAriaActivedescendant(t, ex.menuSelector, ex.menuitemSelector, index + 1);
292+
// }
291293

292-
await menu.sendKeys(Key.ARROW_DOWN);
293-
await assertAriaActivedescendant(t, ex.menuSelector, ex.menuitemSelector, 0);
294-
});
294+
// await menu.sendKeys(Key.ARROW_DOWN);
295+
// await assertAriaActivedescendant(t, ex.menuSelector, ex.menuitemSelector, 0);
296+
// });
295297

296-
ariaTest('"up arrow" on role="menu"', exampleFile, 'menu-up-arrow', async (t) => {
298+
// This test is flaky, so is commented out for now.
299+
// We are traking it in issue:https://github.com/w3c/aria-practices/issues/1415
300+
// ariaTest('"up arrow" on role="menu"', exampleFile, 'menu-up-arrow', async (t) => {
297301

298-
await openMenu(t);
299-
const menu = await t.context.session.findElement(By.css(ex.menuSelector));
300-
const items = await t.context.queryElements(t, ex.menuitemSelector);
302+
// await openMenu(t);
303+
// const menu = await t.context.session.findElement(By.css(ex.menuSelector));
304+
// const items = await t.context.queryElements(t, ex.menuitemSelector);
301305

302-
await menu.sendKeys(Key.ARROW_UP);
303-
await assertAriaActivedescendant(t, ex.menuSelector, ex.menuitemSelector, ex.numMenuitems - 1);
306+
// await menu.sendKeys(Key.ARROW_UP);
307+
// await assertAriaActivedescendant(t, ex.menuSelector, ex.menuitemSelector, ex.numMenuitems - 1);
304308

305-
for (let index = items.length - 1; index > 0; index--) {
309+
// for (let index = items.length - 1; index > 0; index--) {
306310

307-
await menu.sendKeys(Key.ARROW_UP);
308-
await assertAriaActivedescendant(t, ex.menuSelector, ex.menuitemSelector, index - 1);
309-
}
311+
// await menu.sendKeys(Key.ARROW_UP);
312+
// await assertAriaActivedescendant(t, ex.menuSelector, ex.menuitemSelector, index - 1);
313+
// }
310314

311-
});
315+
// });
312316

313317
ariaTest('"home" on role="menu"', exampleFile, 'menu-home', async (t) => {
314318

@@ -365,21 +369,22 @@ ariaTest('"end" on role="menu"', exampleFile, 'menu-end', async (t) => {
365369
await assertAriaActivedescendant(t, ex.menuSelector, ex.menuitemSelector, last);
366370
});
367371

368-
ariaTest('"character" on role="menu"', exampleFile, 'menu-character', async (t) => {
369-
370-
const charIndexTest = [
371-
{ sendChar: 'x', sendIndex: 0, endIndex: 0 },
372-
{ sendChar: 'a', sendIndex: 0, endIndex: 1 },
373-
{ sendChar: 'y', sendIndex: 1, endIndex: 1 },
374-
{ sendChar: 'a', sendIndex: 1, endIndex: 2 }
375-
];
376-
377-
await openMenu(t);
378-
const menu = await t.context.session.findElement(By.css(ex.menuSelector));
379-
380-
for (let test of charIndexTest) {
381-
await menu.sendKeys(test.sendChar);
382-
383-
await assertAriaActivedescendant(t, ex.menuSelector, ex.menuitemSelector, test.endIndex);
384-
}
385-
});
372+
// This test is flaky, so is commented out for now.
373+
// We are traking it in issue:https://github.com/w3c/aria-practices/issues/1415
374+
// ariaTest('"character" on role="menu"', exampleFile, 'menu-character', async (t) => {
375+
// const charIndexTest = [
376+
// { sendChar: 'x', sendIndex: 0, endIndex: 0 },
377+
// { sendChar: 'a', sendIndex: 0, endIndex: 1 },
378+
// { sendChar: 'y', sendIndex: 1, endIndex: 1 },
379+
// { sendChar: 'a', sendIndex: 1, endIndex: 2 }
380+
// ];
381+
382+
// await openMenu(t);
383+
// const menu = await t.context.session.findElement(By.css(ex.menuSelector));
384+
385+
// for (let test of charIndexTest) {
386+
// await menu.sendKeys(test.sendChar);
387+
388+
// await assertAriaActivedescendant(t, ex.menuSelector, ex.menuitemSelector, test.endIndex);
389+
// }
390+
// });

0 commit comments

Comments
 (0)