Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels on sort direction for overall status are inverted and sort has undesirable side-effect on test plan name column in Test Plan Status Summary Table #786

Closed
mcking65 opened this issue Sep 22, 2023 · 3 comments · Fixed by #790
Assignees
Labels
bug Something isn't working

Comments

@mcking65
Copy link

mcking65 commented Sep 22, 2023

From #648, referenced by #654:

Default Table Sort

  • First sort by overall status descending: recommended plans, then candidate plans, then draft plans, then R&D complete plans.
  • Then sort by test plan name ascending.
  • Then sort by Covered AT ascending

Note that the requirements define:

  • DESCENDING ORDER as: recommended , candidate, draft, R&D complete.
  • ASCENDING ORDER as: R&D complete, draft, candidate, recommended.

There are two problems.

Problem 1: sort direction label

The table has the correct default sort order of overall status descending and test plan name ascending. However, the column header on overall status incorrectly represents the sort order as ascending. At least that is how it is communicated via aria-sort, and I assume the sort icon is matching aria-sort.

Problem 2: side effect on test plan sort.

The specification in #648 has a gap. It didn't state what should happen to the test plan column when changing the sort order of the overall status. It should have stated that test plan should stay sorted alphabetically ascending when changing the direction of sort for overall status. Currently, toggling the sort on overall status is also toggling the sort on test plan. It should not do that.

This should also be true for covered AT. However, we have the problem that we only have one set of covered AT for now.

@stalgiag
Copy link
Contributor

Thank you for this. Both issues should be addressed by #790 .

@ccanash
Copy link
Contributor

ccanash commented Oct 4, 2023

Hi @mcking65 flagging this was included in the release from yesterday.

@ccanash ccanash closed this as completed Oct 4, 2023
@ccanash ccanash moved this from In staging/sandbox to In production / Completed in MVP support of ARIA-AT Working Mode by ARIA-AT App - 2023 H1 Project Oct 4, 2023
@mcking65
Copy link
Author

I have verified the fix in prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
4 participants