Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows to the CI build #1793

Open
iamdefinitelyahuman opened this issue Dec 30, 2019 · 1 comment
Open

Add Windows to the CI build #1793

iamdefinitelyahuman opened this issue Dec 30, 2019 · 1 comment

Comments

@iamdefinitelyahuman
Copy link
Contributor

The Issue

We cannot run the full test suite on Windows because of issues with pyethash (Consensys/ethjsonrpc#5), which is a requirement for pyevm (ethereum/py-evm#395).

The Solution

Create a Windows build that runs a limited set of tests to verify the functionality of the CLI. This is the only area of the code base that touches the file system - the most likely area for cross-platform issues.

Originally discussed at #1781 (comment)

@fubuloubu
Copy link
Member

As a part of this, the CLI tests would need to be their own separate part of the CI process to allow this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants