refactor: replace fits word with within word

Author: vursen

src/dimension-observer.js

@@ -46,8 +46,8 @@ function createDimensionObserver(callback, {
 
     let pathHeight  = finishPoint - startPoint;
 
-    let isSideInnerFitsViewport = dim$sideInner.height + topSpacing + bottomSpacing < dim$viewport.height;
-    let isSideInnerFitsPath     = dim$sideInner.height < pathHeight;
+    let isSideInnerWithinViewport = dim$sideInner.height + topSpacing + bottomSpacing < dim$viewport.height;
+    let isSideInnerWithinPath     = dim$sideInner.height < pathHeight;
 
     let sideOuterHeight = Math.max(dim$sideInner.height, pathHeight);
 
@@ -57,8 +57,8 @@ function createDimensionObserver(callback, {
       topSpacing,
       bottomSpacing,
       scrollDirection,
-      isSideInnerFitsPath,
-      isSideInnerFitsViewport,
+      isSideInnerWithinPath,
+      isSideInnerWithinViewport,
 
       sideOuterHeight: sideOuterHeight,
 

src/fsm-transitions.js

@@ -5,32 +5,32 @@ export default {
     {
       to: states.FINISH,
       when: (d) => [
-        d.isSideInnerFitsPath === true,
-        d.isSideInnerFitsViewport === false,
+        d.isSideInnerWithinPath === true,
+        d.isSideInnerWithinViewport === false,
         d.viewportBottom > d.finishPoint
       ]
     },
     {
       to: states.FINISH,
       when: (d) => [
-        d.isSideInnerFitsPath === true,
-        d.isSideInnerFitsViewport === true,
+        d.isSideInnerWithinPath === true,
+        d.isSideInnerWithinViewport === true,
         d.viewportTop + d.sideInnerHeight + d.bottomSpacing > d.finishPoint
       ]
     },
     {
       to: states.BOTTOM_FIXED,
       when: (d) => [
-        d.isSideInnerFitsPath === true,
-        d.isSideInnerFitsViewport === false,
+        d.isSideInnerWithinPath === true,
+        d.isSideInnerWithinViewport === false,
         d.viewportBottom > d.sideInnerBottom + d.bottomSpacing
       ],
     },
     {
       to: states.TOP_FIXED,
       when: (d) => [
-        d.isSideInnerFitsPath === true,
-        d.isSideInnerFitsViewport === true,
+        d.isSideInnerWithinPath === true,
+        d.isSideInnerWithinViewport === true,
         d.viewportTop > d.startPoint - d.topSpacing
       ]
     }
@@ -39,7 +39,7 @@ export default {
   [states.TOP_FIXED]: [
     {
       to: states.START,
-      when: (d) => [d.isSideInnerFitsPath === false],
+      when: (d) => [d.isSideInnerWithinPath === false],
     },
     {
       to: states.START,
@@ -53,15 +53,15 @@ export default {
       to: states.UNFIXED,
       when: (d) => [
         d.scrollDirection === 'down',
-        d.isSideInnerFitsViewport === false
+        d.isSideInnerWithinViewport === false
       ]
     },
   ],
 
   [states.UNFIXED]: [
     {
       to: states.START,
-      when: (d) => [d.isSideInnerFitsPath === false],
+      when: (d) => [d.isSideInnerWithinPath === false],
     },
     {
       to: states.START,
@@ -81,14 +81,14 @@ export default {
     {
       to: states.TOP_FIXED,
       when: (d) => [
-        d.isSideInnerFitsViewport === true,
+        d.isSideInnerWithinViewport === true,
         d.viewportBottom >= d.sideInnerBottom + d.bottomSpacing
       ]
     },
     {
       to: states.BOTTOM_FIXED,
       when: (d) => [
-        d.isSideInnerFitsViewport === false,
+        d.isSideInnerWithinViewport === false,
         d.viewportBottom > d.sideInnerBottom + d.bottomSpacing
       ]
     }
@@ -97,12 +97,12 @@ export default {
   [states.BOTTOM_FIXED]: [
     {
       to: states.START,
-      when: (d) => [d.isSideInnerFitsPath === false],
+      when: (d) => [d.isSideInnerWithinPath === false],
     },
     {
       to: states.START,
       when: (d) => [
-        d.isSideInnerFitsPath === true,
+        d.isSideInnerWithinPath === true,
         d.sideInnerTop <= d.startPoint - d.topSpacing
       ]
     },
@@ -112,7 +112,7 @@ export default {
     },
     {
       to: states.TOP_FIXED,
-      when: (d) => [d.isSideInnerFitsViewport === true,]
+      when: (d) => [d.isSideInnerWithinViewport === true,]
     },
     {
       to: states.FINISH,
@@ -123,7 +123,7 @@ export default {
   [states.FINISH]: [
     {
       to: states.START,
-      when: (d) => [d.isSideInnerFitsPath === false],
+      when: (d) => [d.isSideInnerWithinPath === false],
     },
     {
       to: states.START,

test/transitions.test.js

@@ -73,13 +73,13 @@ describe('transitions', function() {
     });
   });
 
-  // isSideInnerFitsViewport === true
+  // isSideInnerWithinViewport === true
   describe('when height(sidebarInner) < height(viewport)', () => {
     beforeEach(() => {
       setSidebarInnerHeight(VIEWPORT_HEIGHT / 2);
     });
 
-    // isSideInnerFitsPath === false
+    // isSideInnerWithinPath === false
     describe('when height(content) < height(sidebarInner)', () => {
       beforeEach(async () => {
         setContentHeight(sidebarInnerHeight / 2);
@@ -95,7 +95,7 @@ describe('transitions', function() {
       });
     });
 
-    // isSideInnerFitsPath === true
+    // isSideInnerWithinPath === true
     describe('when height(content) > height(sidebarInner)', () => {
       beforeEach(async () => {
         setContentHeight(sidebarInnerHeight * 2);
@@ -180,13 +180,13 @@ describe('transitions', function() {
     });
   });
 
-  // isSideInnerFitsViewport === false
+  // isSideInnerWithinViewport === false
   describe('when height(sidebarInner) > height(viewport)', () => {
     beforeEach(() => {
       setSidebarInnerHeight(VIEWPORT_HEIGHT * 2);
     });
 
-    // isSideInnerFitsPath === false
+    // isSideInnerWithinPath === false
     describe('when height(content) < height(sidebarInner)', () => {
       beforeEach(async () => {
         setContentHeight(sidebarInnerHeight / 2);
@@ -202,7 +202,7 @@ describe('transitions', function() {
       });
     });
 
-    // isSideInnerFitsPath === true
+    // isSideInnerWithinPath === true
     describe('when height(content) > height(sidebarInner)', () => {
       beforeEach(async () => {
         setContentHeight(sidebarInnerHeight * 1.5);