Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.2 seems to have broken something #416

Closed
theDanielJLewis opened this issue Dec 3, 2020 · 3 comments · Fixed by #417
Closed

1.0.2 seems to have broken something #416

theDanielJLewis opened this issue Dec 3, 2020 · 3 comments · Fixed by #417
Assignees
@spencerkordecki
Labels
bug Something isn't working
Milestone
v1.0.3

Comments

@theDanielJLewis
Copy link

I have not changed my Vultr code at all, and vultr-node 1.0.2 seems to have broken things for me. It's not connecting with the Vultr API anymore for creation or deletion.

I receive no error messages, simply a silent hang.

Before 1.0.2, I was manually forcing number fields to Number type. But that shouldn't make a difference for 1.0.2, right?
@theDanielJLewis theDanielJLewis added the bug Something isn't working label Dec 3, 2020
@spencerkordecki
Copy link
Collaborator

1.0.2 includes #397 which allows for passing in both String and Number for endpoints that require a parameter. I'm investigating now and seeing what the issue is here on 1.0.2, and specifically with Number typed variables being sent in.

@spencerkordecki spencerkordecki added in progress This issue is being worked on bug Something isn't working and removed bug Something isn't working labels Dec 3, 2020
@spencerkordecki spencerkordecki modified the milestones: v1.0.2, 1.0.2.1 Dec 3, 2020
@spencerkordecki spencerkordecki mentioned this issue Dec 3, 2020
Merged
3 tasks
@spencerkordecki spencerkordecki removed the in progress This issue is being worked on label Dec 3, 2020
@spencerkordecki
Copy link
Collaborator

@theDanielJLewis fixed in release 1.0.3!

@theDanielJLewis
Copy link
Author

I'm sorry it took me a while to confirm, but this does, indeed, seem to be fixed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spencerkordecki spencerkordecki

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0.3
Development

Successfully merging a pull request may close this issue.

fix type checking of user parameters when passing in numbers and strings vultr/vultr-node
3 participants
@theDanielJLewis @ddymko @spencerkordecki