Remove Database from Model #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandialpad
commented
Nov 8, 2021
| import { createStore, fillState, assertState } from 'test/Helpers' | ||
| import { Model, Attr, Str } from '@/index' | ||
|
|
||
| describe('feature/model/deletes_delete', () => { |
There was a problem hiding this comment.
The following method is deleted so we no longer need these tests.
ryandialpad
commented
Nov 8, 2021
| import { createStore, fillState, assertState } from 'test/Helpers' | ||
| import { Model, Attr, Str } from '@/index' | ||
|
|
||
| describe('feature/model/deletes_delete_composite_key', () => { |
There was a problem hiding this comment.
The following method is deleted so we no longer need these tests.
Comment on lines
-11
to
-13
| it('throws when accessing the database but it is not injected', () => { | ||
| expect(() => new User().$database()).toThrow() | ||
| }) |
There was a problem hiding this comment.
The database is no longer injected into the model so we no longer need this test.
| @@ -22,7 +22,6 @@ describe('unit/repository/Repository', () => { | |||
| const user = store.$repo(User).make() | |||
There was a problem hiding this comment.
Removing expectations of injected databases into the Model.
kiaking
approved these changes
Nov 12, 2021
Thanks!!!!! 🙌 🎉 |
kiaking
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Breaking changes:
The following attributes have been removed from the
Model:_databaseThe following methods have been removed from the
Model:$database$setDatabase$query$delete$deleteByKeyName$deleteByCompositeKeyNameDetails
Purpose
The purpose of this PR is to remove
Databaseaccess from theModelin order to simplify theModeland enforce a repository pattern when using the ORM. This means that we will stop relying on theModelto retrieve anotherModeland instead use theRepositoryorDatabaseto fetch any other models.Changes
DatabasefromModel& any other associated methods