Morph One #91
Merged
Morph One #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Y up the tests a bit
ryandialpad
commented
Nov 2, 2021
ryandialpad
commented
Nov 2, 2021
|
I recommend squashing this PR when it is ready to be merged 😬 |
kiaking
reviewed
Nov 8, 2021
There was a problem hiding this comment.
@ryandialpad This is looking amazing! I've added a test case for make method to increase the coverage. But everything else looking good to me.
Once we resolve the discussion we have with the property names, I think we are ready to merge this 👍
Thanks for the feedback! Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Breaking changes:
Details
Closes #90
Adds Morph One Polymorphic relation & accompanying tests. Follow-up PR to add documentation.
The tests were created following the existing feature test pattern for the other relations.