From e82aa920ecaa58ec7bd50204a6e6a165d5341958 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Szymon=20Dziewo=C5=84ski?= Date: Wed, 4 Oct 2023 17:25:53 +0200 Subject: [PATCH] fix: inheritance attribute for react icons (#3005) --- .changeset/chatty-cameras-leave.md | 5 +++++ createIcons.js | 4 ++-- .../frameworks/react/components/SfIconBase/SfIconBase.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconAdd.tsx | 2 +- .../react/components/SfIcons/SfIconAddShoppingCart.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconArrowBack.tsx | 2 +- .../react/components/SfIcons/SfIconArrowDownward.tsx | 2 +- .../react/components/SfIcons/SfIconArrowForward.tsx | 2 +- .../react/components/SfIcons/SfIconArrowUpward.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconBlock.tsx | 2 +- .../react/components/SfIcons/SfIconCalendarToday.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconCall.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconCancel.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconCheck.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconCheckBox.tsx | 2 +- .../react/components/SfIcons/SfIconCheckBoxOutlineBlank.tsx | 2 +- .../react/components/SfIcons/SfIconCheckCircle.tsx | 2 +- .../react/components/SfIcons/SfIconChevronLeft.tsx | 2 +- .../react/components/SfIcons/SfIconChevronRight.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconCircle.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconClose.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconCloseSm.tsx | 2 +- .../react/components/SfIcons/SfIconCompareArrows.tsx | 2 +- .../react/components/SfIcons/SfIconContactSupport.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconCreditCard.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconDelete.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconEmail.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconError.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconExpandLess.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconExpandMore.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconFacebook.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconFavorite.tsx | 2 +- .../react/components/SfIcons/SfIconFavoriteFilled.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconGridView.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconHelp.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconHome.tsx | 2 +- .../react/components/SfIcons/SfIconIndeterminateCheckBox.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconInfo.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconInstagram.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconLanguage.tsx | 2 +- .../react/components/SfIcons/SfIconLocalShipping.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconLocationOn.tsx | 2 +- .../react/components/SfIcons/SfIconLocationOnFilled.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconLock.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconLockOpen.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconLogin.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconLogout.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconMenu.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconMoreHoriz.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconMoreVert.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconOpenInNew.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconOpenSource.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconPackage.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconPercent.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconPerson.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconPinterest.tsx | 2 +- .../react/components/SfIcons/SfIconPublishedWithChanges.tsx | 2 +- .../react/components/SfIcons/SfIconRadioButtonChecked.tsx | 2 +- .../react/components/SfIcons/SfIconRadioButtonUnchecked.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconReact.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconRemove.tsx | 2 +- .../react/components/SfIcons/SfIconRemoveShoppingCart.tsx | 2 +- .../react/components/SfIcons/SfIconSafetyCheck.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconSchedule.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconSearch.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconSell.tsx | 2 +- .../react/components/SfIcons/SfIconShoppingCart.tsx | 2 +- .../react/components/SfIcons/SfIconShoppingCartCheckout.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconSort.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconStar.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconStarFilled.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconStarHalf.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconThumbDown.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconThumbUp.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconTune.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconTwitter.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconUnfoldMore.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconViewList.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconVisibility.tsx | 2 +- .../react/components/SfIcons/SfIconVisibilityOff.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconVsfDiamond.tsx | 2 +- .../sfui/frameworks/react/components/SfIcons/SfIconVuejs.tsx | 2 +- .../react/components/SfIcons/SfIconVuestorefront.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconWarehouse.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconWarning.tsx | 2 +- .../frameworks/react/components/SfIcons/SfIconYoutube.tsx | 2 +- .../react/components/SfRatingButton/SfRatingButton.tsx | 1 - .../sfui/frameworks/vue/components/SfIcons/SfIconAdd.vue | 2 +- .../vue/components/SfIcons/SfIconAddShoppingCart.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconArrowBack.vue | 2 +- .../vue/components/SfIcons/SfIconArrowDownward.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconArrowForward.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconArrowUpward.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconBlock.vue | 2 +- .../vue/components/SfIcons/SfIconCalendarToday.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconCall.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconCancel.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconCheck.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconCheckBox.vue | 2 +- .../vue/components/SfIcons/SfIconCheckBoxOutlineBlank.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconCheckCircle.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconChevronLeft.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconChevronRight.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconCircle.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconClose.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconCloseSm.vue | 2 +- .../vue/components/SfIcons/SfIconCompareArrows.vue | 2 +- .../vue/components/SfIcons/SfIconContactSupport.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconCreditCard.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconDelete.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconEmail.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconError.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconExpandLess.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconExpandMore.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconFacebook.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconFavorite.vue | 2 +- .../vue/components/SfIcons/SfIconFavoriteFilled.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconGridView.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconHelp.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconHome.vue | 2 +- .../vue/components/SfIcons/SfIconIndeterminateCheckBox.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconInfo.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconInstagram.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconLanguage.vue | 2 +- .../vue/components/SfIcons/SfIconLocalShipping.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconLocationOn.vue | 2 +- .../vue/components/SfIcons/SfIconLocationOnFilled.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconLock.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconLockOpen.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconLogin.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconLogout.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconMenu.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconMoreHoriz.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconMoreVert.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconOpenInNew.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconOpenSource.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconPackage.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconPercent.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconPerson.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconPinterest.vue | 2 +- .../vue/components/SfIcons/SfIconPublishedWithChanges.vue | 2 +- .../vue/components/SfIcons/SfIconRadioButtonChecked.vue | 2 +- .../vue/components/SfIcons/SfIconRadioButtonUnchecked.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconReact.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconRemove.vue | 2 +- .../vue/components/SfIcons/SfIconRemoveShoppingCart.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconSafetyCheck.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconSchedule.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconSearch.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconSell.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconShoppingCart.vue | 2 +- .../vue/components/SfIcons/SfIconShoppingCartCheckout.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconSort.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconStar.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconStarFilled.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconStarHalf.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconThumbDown.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconThumbUp.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconTune.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconTwitter.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconUnfoldMore.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconViewList.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconVisibility.vue | 2 +- .../vue/components/SfIcons/SfIconVisibilityOff.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconVsfDiamond.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconVuejs.vue | 2 +- .../vue/components/SfIcons/SfIconVuestorefront.vue | 2 +- .../frameworks/vue/components/SfIcons/SfIconWarehouse.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconWarning.vue | 2 +- .../sfui/frameworks/vue/components/SfIcons/SfIconYoutube.vue | 2 +- .../tests/components/SfRatingButton/SfRatingButton.cy.tsx | 4 +--- 171 files changed, 175 insertions(+), 173 deletions(-) create mode 100644 .changeset/chatty-cameras-leave.md diff --git a/.changeset/chatty-cameras-leave.md b/.changeset/chatty-cameras-leave.md new file mode 100644 index 0000000000..502cc2ae6a --- /dev/null +++ b/.changeset/chatty-cameras-leave.md @@ -0,0 +1,5 @@ +--- +'@storefront-ui/react': patch +--- + +Fix inhertiance of react icons, possibility to alter default attributes diff --git a/createIcons.js b/createIcons.js index 30d26a9078..dd6277d912 100644 --- a/createIcons.js +++ b/createIcons.js @@ -96,7 +96,7 @@ const vueIcon = (name, content, attributes) => ` ${content}