diff --git a/.changeset/short-lions-develop.md b/.changeset/short-lions-develop.md new file mode 100644 index 0000000000..8ec88e5826 --- /dev/null +++ b/.changeset/short-lions-develop.md @@ -0,0 +1,6 @@ +--- +'@storefront-ui/react': patch +'@storefront-ui/vue': patch +--- + +Unify code between vue and react, when buttons are disabled in floating button position mode they should be hidden diff --git a/apps/docs/components/components/scrollable.md b/apps/docs/components/components/scrollable.md index 8454b0e85a..41ef0a1bd0 100644 --- a/apps/docs/components/components/scrollable.md +++ b/apps/docs/components/components/scrollable.md @@ -15,14 +15,10 @@ This component is shipped in our NPM package, but its API might change based on ::: read-more - Learn more about `useScrollable` hook in the [Hooks > useScrollable docs](/react/hooks/useScrollable.html). - - Learn more about `useScrollable` composable in the [Composables > useScrollable docs](/vue/hooks/useScrollable.html). - ::: @@ -36,14 +32,10 @@ Can be setup that will be without scrollbar - <<<../../preview/nuxt/pages/showcases/Scrollable/HideScrollbar.vue - - <<<../../preview/next/pages/showcases/Scrollable/HideScrollbar.tsx#source - @@ -55,14 +47,10 @@ Can be setup that will be without scrollbar - <<<../../preview/nuxt/pages/showcases/Scrollable/SnapCenter.vue - - <<<../../preview/next/pages/showcases/Scrollable/SnapCenter.tsx#source - @@ -74,14 +62,10 @@ By default `SfScrollable` scroll by one page of items, but can be modified that - <<<../../preview/nuxt/pages/showcases/Scrollable/ScrollByOneItem.vue - - <<<../../preview/next/pages/showcases/Scrollable/ScrollByOneItem.tsx#source - @@ -157,14 +141,11 @@ The previous and next buttons have `aria-label` attributes (`buttonPrevAriaLabel - <<<../../../packages/sfui/frameworks/vue/components/SfScrollable/SfScrollable.vue - - <<< ../../../packages/sfui/frameworks/react/components/SfScrollable/SfScrollable.tsx - + :::::: diff --git a/packages/sfui/frameworks/react/components/SfScrollable/SfScrollable.tsx b/packages/sfui/frameworks/react/components/SfScrollable/SfScrollable.tsx index 222343b22c..74234e4bed 100644 --- a/packages/sfui/frameworks/react/components/SfScrollable/SfScrollable.tsx +++ b/packages/sfui/frameworks/react/components/SfScrollable/SfScrollable.tsx @@ -92,8 +92,8 @@ const SfScrollable = polymorphicForwardRef, ariaLabel: buttonPrevAriaLabel, className: classNames( - 'hidden md:block !ring-neutral-500 !text-neutral-500 disabled:!ring-disabled-300 disabled:!text-disabled-500', classNameButton, + isFloating ? 'disabled:hidden' : 'disabled:!ring-disabled-300 disabled:!text-disabled-500', ), })} /> @@ -114,8 +114,8 @@ const SfScrollable = polymorphicForwardRef, ariaLabel: buttonNextAriaLabel, className: classNames( - 'hidden md:block !ring-neutral-500 !text-neutral-500 disabled:!ring-disabled-300 disabled:!text-disabled-500', classNameButton, + isFloating ? 'disabled:hidden' : 'disabled:!ring-disabled-300 disabled:!text-disabled-500', ), })} /> @@ -131,7 +131,7 @@ const SfScrollable = polymorphicForwardRef {buttonsPlacement !== SfScrollableButtonsPlacement.none && (