New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vue-server-renderer: falsy styles are not filtered #9268

Closed

TheAlexLichter opened this issue Dec 29, 2018 · 3 comments

Contributor

TheAlexLichter commented Dec 29, 2018 •

edited

Loading

Version

2.5.21

Reproduction link

https://github.com/manniL/vue-server-renderer-falsy-styles-bug/

Steps to reproduce

Clone repo
Install deps
Run src/index.js

What is expected?

<h1 data-server-rendered="true" style="color: 'red'">Welcome!!</h1>

What is actually happening?

<h1 data-server-rendered="true" style="height:null;color:red;">Welcome!!</h1>

Related

The text was updated successfully, but these errors were encountered:

Member

posva commented Dec 29, 2018

Duplicate of #9231

posva marked this as a duplicate of #9231

posva closed this as completed

Member

yyx990803 commented Jan 11, 2019

@manniL incidentally fixing this causes some Nuxt test cases to fail: https://circleci.com/gh/vuejs/regression-testing/143

Contributor Author

TheAlexLichter commented Jan 11, 2019 •

edited

Loading

@yyx990803 Thanks for the heads up! Looks like most of them are related to the fix itself (where just the HTML string mismatches).

Not sure why the timing-related tests fail though.
Will dig in ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment