Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vue-loader v12.* to [email protected] so that [email protected] can be used #951

Closed
mkelley33 opened this issue Aug 23, 2017 · 4 comments

Comments

@mkelley33
Copy link

Version

12.2.2

Reproduction link

MoOx/postcss-cssnext#412

Steps to reproduce

Start a new project using vue-cli. Install [email protected]. Add CSS as in MoOx/postcss-cssnext#412. Build.

What is expected?

That nested CSS is processed into CSS that works across browsers.

What is actually happening?

Webpack is erroring as mentioned in MoOx/postcss-cssnext#412


Thank you for your time and consideration. I'll be happy to answer any further questions or respond to comments you may have.

@LinusBorg
Copy link
Member

LinusBorg commented Aug 23, 2017

FYI vue-loader 13.0.0 already has bumped post-css to 6.0.*.

I assume you did not update vue-loader because of the necessary changes that come with its breaking change about default exports?

I think we can do a quick maintenance release for vue-loader 12.2.*

@yyx990803 WDYT?

@LinusBorg LinusBorg changed the title Update to [email protected] so that [email protected] can be used Update vue-loader v12.* to [email protected] so that [email protected] can be used Aug 23, 2017
@yyx990803
Copy link
Member

@LinusBorg hmm, I only bumped it in 13.0 because technically it was a breaking change (postcss 6.0 may not be compatible with old plugins)

My suggestion would be to upgrade to 13.0 since the breaking change is trivial to work around with and with latest vue and vue-loader it should be a smooth upgrade.

@LinusBorg
Copy link
Member

Hm ok, I understand that makes sense.

@mkelley33 Your should also upgrad vue-router so that lazy components are resolved correctly with vue-loader 13.

@mkelley33
Copy link
Author

@LinusBorg @yyx990803 thanks guys, I used vue-cli to create my project and just got the vue-loader that came with that. I'll make the upgrade. The tips are much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants