Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty css module block should not be ignored #1503

Open
Astray-git opened this issue Mar 4, 2019 · 0 comments
Open

Empty css module block should not be ignored #1503

Astray-git opened this issue Mar 4, 2019 · 0 comments

Comments

@Astray-git
Copy link

Astray-git commented Mar 4, 2019

Version

15.7.0

Reproduction link

https://codesandbox.io/s/vmlxvlwo4l

Steps to reproduce

  1. edit example/source.vue with an empty css module block
  2. yarn dev

What is expected?

The text "hello" rendered correctly ( as before 15.5.1 ). with warnings in console.
Or, emit a compile error about empty css module block

What is actually happening?

Compiled successfully.
Runtime error in page: Cannot read property 'red' of undefined


Related: #1464 #1496

Possible solutions:

  1. emit error on empty css module block.
  2. generate empty normally ( as before 15.5.1 ), then emit warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant