Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

fix: add extension to Vue block URI #352

Merged
merged 1 commit into from
May 25, 2020
Merged

fix: add extension to Vue block URI #352

merged 1 commit into from
May 25, 2020

Conversation

znck
Copy link
Member

@znck znck commented May 23, 2020

URI for <script lang="ts"> block would be example.vue?vue&type=script&lang=ts#.ts. The fragment part #.ts is important for other rollup plugins to recognise the correct file type without additional configuration.

/cc @yyx990803 please confirm this change doesn't affect vite.

@znck znck requested a review from yyx990803 May 23, 2020 01:34
@znck znck force-pushed the ext-for-block branch from 669fcf0 to 1c4c510 Compare May 23, 2020 01:35
@znck
Copy link
Member Author

znck commented May 23, 2020

CI is not set up, ignore it for this one. 😬

@znck znck merged commit 74b8f6e into next May 25, 2020
@znck znck deleted the ext-for-block branch May 25, 2020 13:54
@znck znck removed the request for review from yyx990803 May 25, 2020 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant