Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No errors in template with ts-check enabled in Vue >= 3.5.7 #4891

Closed
twisterniq opened this issue Sep 27, 2024 · 2 comments
Closed

No errors in template with ts-check enabled in Vue >= 3.5.7 #4891

twisterniq opened this issue Sep 27, 2024 · 2 comments
Labels

Comments

@twisterniq
Copy link

twisterniq commented Sep 27, 2024

Vue - Official extension or vue-tsc version

2.1.6

VSCode version

1.93.1

Vue version

3.5.9

TypeScript version

5.5.4

System Info

No response

package.json dependencies

{
  "name": "vuejs-ts-check-template-bug",
  "version": "0.0.0",
  "private": true,
  "type": "module",
  "dependencies": {
    "vue": "3.5.9"
  }
}

Steps to reproduce

  1. Clone the minimal reproduction.
  2. npm install
  3. Check that there are no errors in App.vue.
  4. If you downgrade to Vue 3.5.6 and check again, you will see that setDate has an error.

What is expected?

The errors in <template> should be shown when // @ts-check exists.

image

What is actually happening?

The errors in <template> are not shown when // @ts-check exists.

image

Link to minimal reproduction

https://github.com/twisterniq/vuejs-ts-check-template-bug

Any additional comments?

No response

@twisterniq
Copy link
Author

twisterniq commented Sep 27, 2024

It seems like it is caused by vuejs/core#11644

I figured it out by installing the vue version from that commit.
npm i https://pkg.pr.new/vuejs/core/vue@9eca65ee9871d1ac878755afa9a3eb1b02030350 (can reproduce the issue).

Then I installed the vue version from the commit before that one in the main branch:
npm i https://pkg.pr.new/vuejs/core/vue@235ea4772ed2972914cf142da8b7ac1fb04f7585 (can't reproduce the issue).

Should I create the issue in https://github.com/vuejs/core?

@KazariEX
Copy link
Collaborator

Feel free to create it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants