fix: don't invoke Vue getters in setter #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chearon
changed the title
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the codepen in the OP of #498 as well as in the application I'm working on.
I'm hoping it's valid to keep the internal value up-to-date rather than invoking the getter each time: I'm unable to prove that hypothesis wrong. It does assume that
getterwill return the last value passed tosetter, but Vue 2's reactive getter/setters do that. I ran the tests with logging if they are different, and verified that situation never happens in the tests.I believe infinite loops can still happen if you create a reactive object directly (
reactive()orset()) or indirectly (obj.x = {}) but this PR solves most of it.Fixes #498