Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sFileList will be 'undefined' when run form.resetFields() #929

Merged
merged 1 commit into from
Jul 7, 2019
Merged

Conversation

luichooy
Copy link

@luichooy luichooy commented Jul 3, 2019

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. If combining Upload Component with Form Component,The Upload component will ocurr Error When running form.resetFields(). This is because that the code form.resetFields() will make fileList to undefined and Upload componenet watching fileList props to updatae sFileList.
  2. Resolve what problem.
  3. Issue: Upload组件与Form组件结合有问题 #925

@netlify
Copy link

netlify bot commented Jul 3, 2019

Deploy preview for ant-desing-vue processing.

Building with commit d71a04c

https://app.netlify.com/sites/ant-desing-vue/deploys/5d1c698f06994300098869f1

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #929 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #929   +/-   ##
=======================================
  Coverage   87.27%   87.27%           
=======================================
  Files         145      145           
  Lines        4817     4817           
  Branches     1421     1422    +1     
=======================================
  Hits         4204     4204           
  Misses        570      570           
  Partials       43       43
Impacted Files Coverage Δ
components/upload/Upload.jsx 78.02% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3239117...d71a04c. Read the comment docs.

@tangjinzhou tangjinzhou merged commit ea74466 into vueComponent:master Jul 7, 2019
@github-actions
Copy link

github-actions bot commented Jul 7, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants