Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAILURE value is not a key-id #183

Closed
sebbASF opened this issue Jul 19, 2022 · 1 comment
Closed

FAILURE value is not a key-id #183

sebbASF opened this issue Jul 19, 2022 · 1 comment

Comments

@sebbASF
Copy link
Contributor

sebbASF commented Jul 19, 2022

PR #180 prevented FAILURE messages from overwriting the key_id:

if not self.key_id: # don't corrupt the key id with 'gpg-exit nnnnn'

As far as I can tell, the value that is associated with the FAILURE key is not a key-id, so should never be used to set the key_id.
So whilst the PR fixed the immediate issue, the key_id could still end up with an invalid value.

I don't know whether the UNEXPECTED message value can be a key_id.

@vsajip
Copy link
Owner

vsajip commented Jul 24, 2022

Closed in #187.

@vsajip vsajip closed this as completed Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants