Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x.extensions.KHR_materials_unlit != null always true #209

Closed
JalalJaberi opened this issue Mar 5, 2019 · 4 comments
Closed

x.extensions.KHR_materials_unlit != null always true #209

JalalJaberi opened this issue Mar 5, 2019 · 4 comments
Assignees
Labels

Comments

@JalalJaberi
Copy link

In UniGLTF\Scripts\IO\MaterialImporter, x.extensions.KHR_materials_unlit != null is always true event when there is no KHR_materials_unlit key presented in gltf material json data.

@JalalJaberi
Copy link
Author

It seems affected by Unity JSONUtility that initialize non-presented variables (in deserializing) with default values. Cause problematic results.

@yutopp
Copy link
Contributor

yutopp commented Mar 6, 2019

Hi. Thank you for your reporting. I'll investigate the probrem.

@yutopp yutopp added the importer label Mar 6, 2019
@yutopp
Copy link
Contributor

yutopp commented Mar 11, 2019

It will be safe when extensions is null on native Windows environments, but it may causes unexpected behaviour when running on UWP environments or extensions is {}.

It seems time has come to replace the JSON deserializer from JSONUtility (But it's a heavy task...).

@PoChang007
Copy link
Contributor

Sorry for the late reply. This issue has been fixed. Please try again with the latest version. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants