Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL8 #293

Closed
Ronaldschouw opened this issue Jul 12, 2019 · 4 comments
Closed

RHEL8 #293

Ronaldschouw opened this issue Jul 12, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@Ronaldschouw
Copy link

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: ALL
  • Ruby:
  • Distribution: RHEL8
  • Module version: ALL

How to reproduce (e.g Puppet code you use)

RHEL8 operatingsystemmajrelease is not supported

What are you seeing

What behaviour did you expect instead

Output log

Any additional information you'd like to impart

Please rewrite spec/classes/selinux_package_spec.rb and manifests/params.pp to support RHEL8

@ghoneycutt
Copy link
Member

Hi @Ronaldschouw could you take a crack at a PR? The VP community is very likely to help you out with the code, though less likely to just add a new OS that they might not be using.

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Jul 14, 2019
@ekohl
Copy link
Member

ekohl commented Jul 17, 2019

It's not listed in metadata.json because I haven't personally tested this but I did merge 07f0748 which made it work for my colleague. In theory it's a matter of running the test suite and adding it to metadata.json.

@blackknight36
Copy link
Contributor

I've opened #294 to address this. I've been doing some testing with RHEL 8 nodes and haven't seen any other issues with the module itself.

@ekohl
Copy link
Member

ekohl commented Jul 17, 2019

Resolved in #294

@ekohl ekohl closed this as completed Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants